Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old features 'clone_from_slice' and 'convert' #9512

Merged
merged 1 commit into from Feb 4, 2016
Merged

Remove old features 'clone_from_slice' and 'convert' #9512

merged 1 commit into from Feb 4, 2016

Conversation

@timvandermeij
Copy link
Contributor

timvandermeij commented Feb 2, 2016

Fixes #9495.

Review on Reviewable
@highfive
Copy link

highfive commented Feb 2, 2016

warning Warning warning

  • These commits modify gfx code, but no tests are modified. Please consider adding a test!
@frewsxcv
Copy link
Member

frewsxcv commented Feb 2, 2016

Thanks!

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 2, 2016

📌 Commit b0d0694 has been approved by frewsxcv
@frewsxcv frewsxcv self-assigned this Feb 2, 2016
@timvandermeij
Remove old features 'clone_from_slice' and 'convert'
Loading status checks…
a9472ed
@timvandermeij
Copy link
Contributor Author

timvandermeij commented Feb 2, 2016

Whoops, I made a mistake in my previous commit. After reading http://chrismorgan.info/blog/rust-cfg_attr.html I now know how cfg_attr works. I have pushed a new patch. Could you check this again and re-trigger the tests?
@nox
Copy link
Member

nox commented Feb 3, 2016

@bors-servo r=frewsxcv
@bors-servo
Copy link
Contributor

bors-servo commented Feb 3, 2016

📌 Commit a9472ed has been approved by frewsxcv
@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2016

⌛ Testing commit a9472ed with merge 4139129...
bors-servo added a commit that referenced this pull request Feb 4, 2016
@bors-servo
Auto merge of #9512 - timvandermeij:feature-cleanup, r=frewsxcv
4139129 
Remove old features 'clone_from_slice' and 'convert'

Fixes #9495.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9512)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2016

💔 Test failed - mac-rel-css
@wafflespeanut
Copy link
Member

wafflespeanut commented Feb 4, 2016 

Cloning into '.'...
fatal: did not receive expected object 961038bb24b2ca4290dfe2d287459ca26b7c256e
fatal: index-pack failed

@bors-servo retry
@wafflespeanut
Copy link
Member

wafflespeanut commented Feb 4, 2016

@bors-servo r=frewsxcv
@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2016

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #9516
@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2016

📌 Commit a9472ed has been approved by frewsxcv
@wafflespeanut
Copy link
Member

wafflespeanut commented Feb 4, 2016

Oooh, sorry :)
@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2016

⌛ Testing commit a9472ed with merge 752c1ea...
bors-servo added a commit that referenced this pull request Feb 4, 2016
@bors-servo
Auto merge of #9512 - timvandermeij:feature-cleanup, r=frewsxcv
752c1ea 
Remove old features 'clone_from_slice' and 'convert'

Fixes #9495.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9512)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member

KiChjang commented Feb 4, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2016

⌛ Testing commit a9472ed with merge 39b4a95...
bors-servo added a commit that referenced this pull request Feb 4, 2016
@bors-servo
Auto merge of #9512 - timvandermeij:feature-cleanup, r=frewsxcv
39b4a95 
Remove old features 'clone_from_slice' and 'convert'

Fixes #9495.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9512)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2016

💔 Test failed - mac-rel-wpt
@wafflespeanut
Copy link
Member

wafflespeanut commented Feb 4, 2016

@bors-servo retry

#8191
@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2016

⌛ Testing commit a9472ed with merge 6476371...
bors-servo added a commit that referenced this pull request Feb 4, 2016
@bors-servo
Auto merge of #9512 - timvandermeij:feature-cleanup, r=frewsxcv
Loading status checks…
6476371 
Remove old features 'clone_from_slice' and 'convert'

Fixes #9495.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9512)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo mentioned this pull request Feb 4, 2016
Merged
@bors-servo bors-servo merged commit a9472ed into servo:master Feb 4, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@timvandermeij timvandermeij deleted the timvandermeij:feature-cleanup branch Feb 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@frewsxcv frewsxcv

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@timvandermeij @highfive @frewsxcv @bors-servo @nox @wafflespeanut @KiChjang
You can’t perform that action at this time.