Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout: Separate out overflow-for-scrolling from overflow-for-paint. #9522

Merged
merged 1 commit into from Feb 5, 2016
Merged

layout: Separate out overflow-for-scrolling from overflow-for-paint. #9522

merged 1 commit into from Feb 5, 2016

Conversation

@pcwalton
Copy link
Contributor

pcwalton commented Feb 3, 2016

Closes #9484.

r? @mbrubeck

Review on Reviewable
@highfive
Copy link

highfive commented Feb 3, 2016

warning Warning warning

  • These commits modify layout code, but no tests are modified. Please consider adding a test!
@mbrubeck mbrubeck self-assigned this Feb 3, 2016
@pcwalton pcwalton force-pushed the pcwalton:two-overflows branch from 3b9fddc to 797ccb2 Feb 3, 2016
tests/html/overflow-box-shadow.html Outdated
@@ -0,0 +1,32 @@
<!DOCTYPE html>
<!-- Nothing on this page should be scrollable. ->

This comment has been minimized.

Sign in to view
Copy link
@timvandermeij

timvandermeij Feb 3, 2016

Contributor

Does -> need to be --> for the comment to work (notice the color change in the GitHub diff).
@mbrubeck
Copy link
Contributor

mbrubeck commented Feb 3, 2016

-S-awaiting-review +S-needs-code-changes

Reviewed 16 of 17 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

components/layout/fragment.rs, line 2203 [r2] (raw file):
I think outlines should only affect the paint overflow. “The outline created with the outline properties is drawn "over" a box, i.e., the outline is always on top, and does not influence the position or size of the box, or of any other boxes.”

Comments from the review on Reviewable.io
@mbrubeck
Copy link
Contributor

mbrubeck commented Feb 3, 2016

Can land with r=mbrubeck with the two review comments addressed.
@pcwalton
layout: Separate out overflow-for-scrolling from overflow-for-paint.
Loading status checks…
7c5b2d6 
Closes #9484.
@pcwalton pcwalton force-pushed the pcwalton:two-overflows branch from 797ccb2 to 7c5b2d6 Feb 4, 2016
@pcwalton
Copy link
Contributor Author

pcwalton commented Feb 4, 2016

@bors-servo: r=mbrubeck
@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2016

📌 Commit 7c5b2d6 has been approved by mbrubeck
@bors-servo
Copy link
Contributor

bors-servo commented Feb 5, 2016

⌛ Testing commit 7c5b2d6 with merge e70d4ed...
bors-servo added a commit that referenced this pull request Feb 5, 2016
@bors-servo
Auto merge of #9522 - pcwalton:two-overflows, r=mbrubeck
e70d4ed 
layout: Separate out overflow-for-scrolling from overflow-for-paint.

Closes #9484.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9522)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 5, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member

KiChjang commented Feb 5, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 5, 2016

⌛ Testing commit 7c5b2d6 with merge cf207c6...
bors-servo added a commit that referenced this pull request Feb 5, 2016
@bors-servo
Auto merge of #9522 - pcwalton:two-overflows, r=mbrubeck
cf207c6 
layout: Separate out overflow-for-scrolling from overflow-for-paint.

Closes #9484.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9522)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 5, 2016

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Feb 5, 2016

@bors-servo: retry
@wafflespeanut
Copy link
Member

wafflespeanut commented Feb 5, 2016

@bors-servo retry

#9033
@bors-servo
Copy link
Contributor

bors-servo commented Feb 5, 2016

⌛ Testing commit 7c5b2d6 with merge fb3fe3d...
bors-servo added a commit that referenced this pull request Feb 5, 2016
@bors-servo
Auto merge of #9522 - pcwalton:two-overflows, r=mbrubeck
Loading status checks…
fb3fe3d 
layout: Separate out overflow-for-scrolling from overflow-for-paint.

Closes #9484.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9522)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 5, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 7c5b2d6 into servo:master Feb 5, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@nox nox mentioned this pull request Feb 5, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrubeck mbrubeck

Labels
A-layout/uncategorized S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
@pcwalton @highfive @mbrubeck @bors-servo @KiChjang @jdm @wafflespeanut @timvandermeij
You can’t perform that action at this time.