Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update immeta dependency to resolve ImageCacheThread panic #9542

Merged
merged 1 commit into from Feb 6, 2016
Merged

Update immeta dependency to resolve ImageCacheThread panic #9542

merged 1 commit into from Feb 6, 2016

Conversation

@timvandermeij
Copy link
Contributor

timvandermeij commented Feb 4, 2016

Fixes #9501.

Before this patch, a website such as http://www.universiteitleiden.nl would consistently crash Servo. After this patch, the website loads just fine.

Review on Reviewable
@highfive
Copy link

highfive commented Feb 4, 2016

warning Warning warning

  • These commits modify net code, but no tests are modified. Please consider adding a test!
@timvandermeij
Update immeta dependency to resolve ImageCacheThread panic
Loading status checks…
f4f42b2
@timvandermeij timvandermeij changed the title Update immeta dependecy to resolve ImageCacheThread panic Update immeta dependency to resolve ImageCacheThread panic Feb 4, 2016
@jdm
Copy link
Member

jdm commented Feb 4, 2016

@bors-servo: r+
Thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2016

📌 Commit f4f42b2 has been approved by jdm
@jdm jdm self-assigned this Feb 4, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Feb 5, 2016

⌛ Testing commit f4f42b2 with merge b0e27d6...
bors-servo added a commit that referenced this pull request Feb 5, 2016
@bors-servo
Auto merge of #9542 - timvandermeij:immeta, r=jdm
b0e27d6 
Update immeta dependency to resolve ImageCacheThread panic

Fixes #9501.

Before this patch, a website such as http://www.universiteitleiden.nl would consistently crash Servo. After this patch, the website loads just fine.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9542)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 5, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member

KiChjang commented Feb 5, 2016

@bors-servo retry
@nox nox added S-awaiting-merge and removed S-tests-failed labels Feb 5, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Feb 5, 2016

⌛ Testing commit f4f42b2 with merge cfdb5be...
bors-servo added a commit that referenced this pull request Feb 5, 2016
@bors-servo
Auto merge of #9542 - timvandermeij:immeta, r=jdm
cfdb5be 
Update immeta dependency to resolve ImageCacheThread panic

Fixes #9501.

Before this patch, a website such as http://www.universiteitleiden.nl would consistently crash Servo. After this patch, the website loads just fine.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9542)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 5, 2016

💔 Test failed - linux-rel
@nox
Copy link
Member

nox commented Feb 5, 2016

@bors-servo retry #9120
@nox nox added S-awaiting-merge and removed S-tests-failed labels Feb 5, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Feb 5, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-unit, mac-rel-css are reusable. Rebuilding only linux-rel, mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 5, 2016

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Feb 5, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 5, 2016

💔 Test failed - mac-rel-wpt
@KiChjang
Copy link
Member

KiChjang commented Feb 5, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 5, 2016

⌛ Testing commit f4f42b2 with merge 769dfde...
bors-servo added a commit that referenced this pull request Feb 5, 2016
@bors-servo
Auto merge of #9542 - timvandermeij:immeta, r=jdm
769dfde 
Update immeta dependency to resolve ImageCacheThread panic

Fixes #9501.

Before this patch, a website such as http://www.universiteitleiden.nl would consistently crash Servo. After this patch, the website loads just fine.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9542)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 5, 2016

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Feb 5, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 5, 2016

⌛ Testing commit f4f42b2 with merge 3498dec...
bors-servo added a commit that referenced this pull request Feb 5, 2016
@bors-servo
Auto merge of #9542 - timvandermeij:immeta, r=jdm
Loading status checks…
3498dec 
Update immeta dependency to resolve ImageCacheThread panic

Fixes #9501.

Before this patch, a website such as http://www.universiteitleiden.nl would consistently crash Servo. After this patch, the website loads just fine.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9542)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 5, 2016

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Feb 5, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 6, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 6, 2016

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Feb 6, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 6, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 6, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit f4f42b2 into servo:master Feb 6, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@timvandermeij timvandermeij deleted the timvandermeij:immeta branch Feb 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@timvandermeij @highfive @jdm @bors-servo @KiChjang @nox
You can’t perform that action at this time.