Fix #9508: Beautify our union enums constructors

[alopatindev]

Solves #9508
@jdm Please review. Thanks!

[highfive]

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon.

[highfive]

Heads up! This PR modifies the following files:

• @ecoal95: components/script/dom/webglrenderingcontext.rs

[highfive]

Warning

• These commits modify script code, but no tests are modified. Please consider adding a test!

[jdm]

I'm actually going to hand this over to @nox, but thanks for doing this!
r? @nox

[alopatindev]

Ok, cool. Please note that I wasn't able to run tests neither on master nor on my branch (is that okay, actually?)

$ ./mach test
tidy reported no errors.
Error running mach:

    ['test']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

TypeError: test_ref() got an unexpected keyword argument 'kind'

  File "/home/sbar/git/servo/python/servo/testing_commands.py", line 152, in test
    Registrar.dispatch("test-%s" % suite, context=self.context, **kwargs)
  File "/home/sbar/git/servo/python/mach/mach/registrar.py", line 115, in dispatch
    return self._run_command_handler(handler, context=context, **kwargs)
  File "/home/sbar/git/servo/python/mach/mach/registrar.py", line 90, in _run_command_handler
    result = fn(**kwargs)

Thanks!

---

Review status: 0 of 13 files reviewed at latest revision, all discussions resolved.

---

Comments from the review on Reviewable.io

[jdm]

I'll file an issue for that, but generally ./mach test will run far, far more tests than you ever want and will make your machine unusable for unrealistic periods of time. In this case, the fact that it compiles is enough to demonstrate validity of the change. For future changes, running particular test harnesses and subdirectories could make more sense (eg. ./mach test-wpt, ./mach test-css, ./mach test-unit).

[bors-servo]

☔ The latest upstream changes (presumably #9521) made this pull request unmergeable. Please resolve the merge conflicts.

[alopatindev]

That was my first rebase, actually. I fixed merge conflict and now I've got a single commit that should be mergeable with master. Hopefully I did it right :) Please check. Thanks

---

Review status: 0 of 112 files reviewed at latest revision, all discussions resolved, some commit checks failed.

---

Comments from the review on Reviewable.io

[KiChjang]

The rebase went horribly wrong. You currently have 14 unrelated commits in your PR. See https://github.com/servo/servo/wiki/Github-Workflow for a guide on how to rebase.

[alopatindev]

@KiChjang thanks for noticing that! I've removed unrelated commits using git rebase -i HEAD~15
Hopefully I didn't make it even worse :)
(But if I actually did—sorry; it's probably easier for me to recreate the PR then)

---

Review status: 0 of 13 files reviewed at latest revision, all discussions resolved.

---

Comments from the review on Reviewable.io

[KiChjang]

Everything looks fine; thanks for addressing this issue!

@bors-servo r+

[bors-servo]

📌 Commit 2be4940 has been approved by KiChjang

[bors-servo]

⌛ Testing commit 2be4940 with merge 28ecb0b...

[bors-servo]

💔 Test failed - mac-rel-css

[frewsxcv]

@bors-servo retry #7791

[bors-servo]

⚡ Previous build results for android, gonk, linux-dev, mac-dev-unit, mac-rel-wpt are reusable. Rebuilding only linux-rel, mac-rel-css...

[bors-servo]

💔 Test failed - linux-rel

[larsbergstrom]

@bors-servo retry

• #7846

[bors-servo]

⚡ Previous build results for android, gonk, linux-dev, mac-dev-unit, mac-rel-wpt are reusable. Rebuilding only linux-rel, mac-rel-css...

[bors-servo]

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt