New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed references of android-rs-glue from comments and documentation #9549
Merged
+4
−6
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.
| @@ -362,10 +362,10 @@ def build_env(self, gonk=False, hosts_file_path=None): | ||
| env["OPENSSL_LIB_DIR"] = openssl_dir | ||
| env['OPENSSL_INCLUDE_DIR'] = path.join(env["GONKDIR"], "external/openssl/include") | ||
|
|
||
| # FIXME: These are set because they are the variable names that | ||
| # android-rs-glue expects. However, other submodules have makefiles that | ||
| # reference the env var names above. Once glutin is enabled and set as | ||
| # the default, we could modify the subproject makefiles to use the names | ||
| # These are set because they are the variable names that build-apk | ||
larsbergstrom
Contributor
|
||
| # expects. However, other submodules have makefiles that reference | ||
| # the env var names above. Once glutin is enabled and set as the | ||
| # default, we could modify the subproject makefiles to use the names | ||
| # below and remove the vars above, to avoid duplication. | ||
| if "ANDROID_SDK" in env: | ||
| env["ANDROID_HOME"] = env["ANDROID_SDK"] | ||
ProTip!
Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This comment is removed, but the code was not changed.