Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed references of android-rs-glue from comments and documentation #9549

Merged
merged 1 commit into from Feb 6, 2016
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

@@ -69,8 +69,6 @@
* support
* android
* Libraries that require special handling for building for Android platforms
* android-rs-glue
* Library to integrate better with Android platforms
* rust-task_info
* Library for obtaining information about memory usage for a process
* target
@@ -362,10 +362,10 @@ def build_env(self, gonk=False, hosts_file_path=None):
env["OPENSSL_LIB_DIR"] = openssl_dir
env['OPENSSL_INCLUDE_DIR'] = path.join(env["GONKDIR"], "external/openssl/include")

# FIXME: These are set because they are the variable names that
# android-rs-glue expects. However, other submodules have makefiles that
# reference the env var names above. Once glutin is enabled and set as
# the default, we could modify the subproject makefiles to use the names
# These are set because they are the variable names that build-apk

This comment has been minimized.

@KiChjang

KiChjang Feb 5, 2016

Member

This comment is removed, but the code was not changed.

This comment has been minimized.

@larsbergstrom

larsbergstrom Feb 5, 2016

Contributor

Yeah, sorry I didn't see this PR come in! He does not need to change the code - just the comment. Sorry I wasn't clear!

# expects. However, other submodules have makefiles that reference
# the env var names above. Once glutin is enabled and set as the
# default, we could modify the subproject makefiles to use the names
# below and remove the vars above, to avoid duplication.
if "ANDROID_SDK" in env:
env["ANDROID_HOME"] = env["ANDROID_SDK"]
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.