Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpgrade to harfbuzz-sys 0.1.3 #9559
Closed
Conversation
This includes the fix for servo/rust-harfbuzz#54, and reverts #9128 which was a temporary workaround for that issue.
|
@bors-servo r+ Reviewed 4 of 4 files at r1. Comments from the review on Reviewable.io |
|
|
|
@metajack @mbrubeck Travis fails. @bors-servo r- |
|
The package on crates.io is broken. See servo/rust-harfbuzz#60. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mbrubeck commentedFeb 5, 2016
This includes the fix for servo/rust-harfbuzz#54, and reverts #9128 which was a temporary workaround for that issue.
r? @metajack