Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump js to get fix from servo/rust-mozjs#237 #9570

Closed
wants to merge 1 commit into from
Closed

Bump js to get fix from servo/rust-mozjs#237 #9570

wants to merge 1 commit into from

Conversation

@nox
Copy link
Member

nox commented Feb 8, 2016

Review on Reviewable
@nox
Bump js to get fix from servo/rust-mozjs#237
Loading status checks…
de56c7b
@Ms2ger
Copy link
Contributor

Ms2ger commented Feb 8, 2016

I wanna test :)
@nox
Copy link
Member Author

nox commented Feb 8, 2016

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Feb 8, 2016

⌛ Trying commit de56c7b with merge b86aede...
bors-servo added a commit that referenced this pull request Feb 8, 2016
@bors-servo
Auto merge of #9570 - servo:bump-js, r=<try>
b86aede 
Bump js to get fix from servo/rust-mozjs#237

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9570)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 8, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member

KiChjang commented Feb 8, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 8, 2016

📌 Commit de56c7b has been approved by KiChjang
@KiChjang KiChjang self-assigned this Feb 8, 2016
@jdm
Copy link
Member

jdm commented Feb 8, 2016

@bors-servo: r-
@Ms2ger was asking for a test that verifies this change, I'm pretty sure.
@KiChjang
Copy link
Member

KiChjang commented Feb 8, 2016

Oh, sorry, didn't read the message.
@KiChjang KiChjang assigned Ms2ger and unassigned KiChjang Feb 9, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Feb 9, 2016

☔ The latest upstream changes (presumably #9584) made this pull request unmergeable. Please resolve the merge conflicts.
@jdm
Copy link
Member

jdm commented Feb 9, 2016

I guess we got the changes in #9584 but still no test.
@nox nox closed this Feb 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ms2ger Ms2ger

Labels
S-awaiting-review S-needs-rebase
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@nox @Ms2ger @bors-servo @KiChjang @jdm @highfive
You can’t perform that action at this time.