Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the global argument to EventTarget::{fire_event, fire_simple_event}. #9571

Merged
merged 1 commit into from Feb 9, 2016
Merged

Remove the global argument to EventTarget::{fire_event, fire_simple_event}. #9571

merged 1 commit into from Feb 9, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Feb 8, 2016

Review on Reviewable
@Ms2ger
Remove the global argument to EventTarget::{fire_event, fire_simple_e…
Loading status checks…
5317af1 
…vent}.
@highfive
Copy link

highfive commented Feb 8, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@asajeffrey asajeffrey self-assigned this Feb 8, 2016
@asajeffrey
Copy link
Member

asajeffrey commented Feb 8, 2016

Yay, the code got a lot cleaner!

Reviewed 9 of 9 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io
@asajeffrey
Copy link
Member

asajeffrey commented Feb 8, 2016

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 8, 2016

📌 Commit 5317af1 has been approved by asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Feb 8, 2016

⌛ Testing commit 5317af1 with merge 0124d90...
bors-servo added a commit that referenced this pull request Feb 8, 2016
@bors-servo
Auto merge of #9571 - Ms2ger:fire, r=asajeffrey
Loading status checks…
0124d90 
Remove the global argument to EventTarget::{fire_event, fire_simple_event}.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9571)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 9, 2016

💔 Test failed - linux-rel
@asajeffrey
Copy link
Member

asajeffrey commented Feb 9, 2016

The CSS failure is probably just an intermittent. The compiler warning is more of a concern, do you know what's causing it?
@KiChjang
Copy link
Member

KiChjang commented Feb 9, 2016

Which compiler warning are you talking about?
@KiChjang
Copy link
Member

KiChjang commented Feb 9, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 9, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 9, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 5317af1 into servo:master Feb 9, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
This was referenced Feb 9, 2016
Merged
Merged
Merged
@asajeffrey
Copy link
Member

asajeffrey commented Feb 9, 2016

The warnings at http://build.servo.org/builders/linux-rel/builds/1822, but if you reckon those are unrelated then yay.
@Ms2ger Ms2ger deleted the Ms2ger:fire branch Feb 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@asajeffrey asajeffrey

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @highfive @asajeffrey @bors-servo @KiChjang
You can’t perform that action at this time.