Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store a pointer to the browsing context in the Document. #9603

Merged
merged 1 commit into from Feb 19, 2016
Merged

Store a pointer to the browsing context in the Document. #9603

merged 1 commit into from Feb 19, 2016
+53 −23

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Feb 11, 2016

Review on Reviewable
@Ms2ger
Store a pointer to the browsing context in the Document.
Loading status checks…
152cec6
@highfive
Copy link

highfive commented Feb 11, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Feb 16, 2016

r? @jdm
@jdm
Copy link
Member

jdm commented Feb 18, 2016

@bors-servo: r+

Reviewed 10 of 10 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io
@bors-servo
Copy link
Contributor

bors-servo commented Feb 18, 2016

📌 Commit 152cec6 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Feb 18, 2016

⌛ Testing commit 152cec6 with merge 8907b7f...
bors-servo added a commit that referenced this pull request Feb 18, 2016
@bors-servo
Auto merge of #9603 - Ms2ger:document-bc, r=jdm
8907b7f 
Store a pointer to the browsing context in the Document.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9603)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 18, 2016

💔 Test failed - mac-rel-css
@KiChjang
Copy link
Member

KiChjang commented Feb 18, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 18, 2016

⌛ Testing commit 152cec6 with merge d225063...
bors-servo added a commit that referenced this pull request Feb 18, 2016
@bors-servo
Auto merge of #9603 - Ms2ger:document-bc, r=jdm
d225063 
Store a pointer to the browsing context in the Document.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9603)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 18, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member

KiChjang commented Feb 19, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 19, 2016

⌛ Testing commit 152cec6 with merge ee158cc...
bors-servo added a commit that referenced this pull request Feb 19, 2016
@bors-servo
Auto merge of #9603 - Ms2ger:document-bc, r=jdm
Loading status checks…
ee158cc 
Store a pointer to the browsing context in the Document.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9603)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 19, 2016

💔 Test failed - mac-dev-unit
@KiChjang
Copy link
Member

KiChjang commented Feb 19, 2016

@bors-servo retry

  • Git problem
@bors-servo
Copy link
Contributor

bors-servo commented Feb 19, 2016

⚡ Previous build results for android, gonk, linux-dev, linux-rel, mac-rel-css are reusable. Rebuilding only mac-dev-unit, mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 19, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 152cec6 into servo:master Feb 19, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Feb 19, 2016
Merged
@Ms2ger Ms2ger deleted the Ms2ger:document-bc branch Feb 23, 2016
This was referenced May 27, 2016
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @highfive @jdm @bors-servo @KiChjang
You can’t perform that action at this time.