Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd a "mach test-wpt --chaos" mode for reproducing intermittent failures using rr #9607
Conversation
|
FYI: the wptrunner changes should be upstreamed, too. |
|
Reviewed 2 of 2 files at r1, 1 of 1 files at r3. python/servo/testing_commands.py, line 349 [r3] (raw file): I guess it's OK for these to overwrite any user-supplied options? Comments from the review on Reviewable.io |
|
@bors-servo r=jgraham -S-awaiting-review
Done. Review status: 2 of 3 files reviewed at latest revision, 1 unresolved discussion. python/servo/testing_commands.py, line 349 [r3] (raw file): Comments from the review on Reviewable.io |
|
|
Add a "mach test-wpt --chaos" mode for reproducing intermittent failures using rr
This adds a new `--chaos` flag to the `test-wpt` and `test-css` commands. This will run a test repeatedly until it fails, recording it with the rr debugger in chaos mode. Requires a recent master build of rr.
```
./mach test-wpt --chaos test.html
```
is shorthand for:
```
./mach test-wpt --repeat-until-unexpected \
--debugger rr \
--debugger-args "record --chaos" \
--include test.html
```
This PR currently includes changes to wptrunner which were also submitted upstream as w3c/wptrunner#170. We should not merge this until that upstream PR is merged. CC @jgraham
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9607)
<!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
|
|
|
|
|
|
|
@bors-servo: retry
|
Add a "mach test-wpt --chaos" mode for reproducing intermittent failures using rr
This adds a new `--chaos` flag to the `test-wpt` and `test-css` commands. This will run a test repeatedly until it fails, recording it with the rr debugger in chaos mode. Requires a recent master build of rr.
```
./mach test-wpt --chaos test.html
```
is shorthand for:
```
./mach test-wpt --repeat-until-unexpected \
--debugger rr \
--debugger-args "record --chaos" \
--include test.html
```
This PR currently includes changes to wptrunner which were also submitted upstream as w3c/wptrunner#170. We should not merge this until that upstream PR is merged. CC @jgraham
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9607)
<!-- Reviewable:end -->
|
|
mbrubeck commentedFeb 11, 2016
This adds a new
--chaosflag to thetest-wptandtest-csscommands. This will run a test repeatedly until it fails, recording it with the rr debugger in chaos mode. Requires a recent master build of rr.is shorthand for:
This PR currently includes changes to wptrunner which were also submitted upstream as w3c/wptrunner#170. We should not merge this until that upstream PR is merged. CC @jgraham