Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding warning to properties.mako.rs regarding the Mako parser mangling #9634

Merged
merged 1 commit into from Feb 15, 2016
Merged

Adding warning to properties.mako.rs regarding the Mako parser mangling #9634

merged 1 commit into from Feb 15, 2016

Conversation

@craftytrickster
Copy link
Contributor

craftytrickster commented Feb 14, 2016

#9564 (comment)

Review on Reviewable
@craftytrickster
Adding warning to properties.mako.rs regarding the Mako parser mangli…
Loading status checks…
8fa82f6 
…ng Rust code
@highfive
Copy link

highfive commented Feb 14, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties.mako.rs
@highfive
Copy link

highfive commented Feb 14, 2016

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@Manishearth
Copy link
Member

Manishearth commented Feb 14, 2016

@bors-servo r+ rollup

Thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Feb 14, 2016

📌 Commit 8fa82f6 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Feb 14, 2016

⌛ Testing commit 8fa82f6 with merge 78ad989...
bors-servo added a commit that referenced this pull request Feb 14, 2016
@bors-servo
Auto merge of #9634 - craftytrickster:issue/9564, r=Manishearth
78ad989 
Adding warning to properties.mako.rs regarding the Mako parser mangling

#9564 (comment)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9634)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 14, 2016

💔 Test failed - mac-rel-css
@Manishearth
Copy link
Member

Manishearth commented Feb 14, 2016

@bors-servo retry

network/git issues
@bors-servo
Copy link
Contributor

bors-servo commented Feb 14, 2016

⌛ Testing commit 8fa82f6 with merge 5f87ac1...
bors-servo added a commit that referenced this pull request Feb 14, 2016
@bors-servo
Auto merge of #9634 - craftytrickster:issue/9564, r=Manishearth
5f87ac1 
Adding warning to properties.mako.rs regarding the Mako parser mangling

#9564 (comment)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9634)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 14, 2016

💔 Test failed - mac-dev-unit
@Manishearth
Copy link
Member

Manishearth commented Feb 14, 2016 

Cloning into '.'...
error: wrong index v2 file size in /Users/servo/buildbot/slave/mac-dev-unit/build/.git/objects/pack/pack-2ae90a5428c30ca4ce86d2e16f73c6c5f54b66b5.idx
error: wrong index v2 file size in /Users/servo/buildbot/slave/mac-dev-unit/build/.git/objects/pack/pack-2ae90a5428c30ca4ce86d2e16f73c6c5f54b66b5.idx
error: wrong index v2 file size in /Users/servo/buildbot/slave/mac-dev-unit/build/.git/objects/pack/pack-2ae90a5428c30ca4ce86d2e16f73c6c5f54b66b5.idx
error: wrong index v2 file size in /Users/servo/buildbot/slave/mac-dev-unit/build/.git/objects/pack/pack-2ae90a5428c30ca4ce86d2e16f73c6c5f54b66b5.idx
error: wrong index v2 file size in /Users/servo/buildbot/slave/mac-dev-unit/build/.git/objects/pack/pack-2ae90a5428c30ca4ce86d2e16f73c6c5f54b66b5.idx
error: wrong index v2 file size in /Users/servo/buildbot/slave/mac-dev-unit/build/.git/objects/pack/pack-2ae90a5428c30ca4ce86d2e16f73c6c5f54b66b5.idx
error: wrong index v2 file size in /Users/servo/buildbot/slave/mac-dev-unit/build/.git/objects/pack/pack-2ae90a5428c30ca4ce86d2e16f73c6c5f54b66b5.idx
error: wrong index v2 file size in /Users/servo/buildbot/slave/mac-dev-unit/build/.git/objects/pack/pack-2ae90a5428c30ca4ce86d2e16f73c6c5f54b66b5.idx
error: wrong index v2 file size in /Users/servo/buildbot/slave/mac-dev-unit/build/.git/objects/pack/pack-2ae90a5428c30ca4ce86d2e16f73c6c5f54b66b5.idx
error: wrong index v2 file size in /Users/servo/buildbot/slave/mac-dev-unit/build/.git/objects/pack/pack-2ae90a5428c30ca4ce86d2e16f73c6c5f54b66b5.idx
error: wrong index v2 file size in /Users/servo/buildbot/slave/mac-dev-unit/build/.git/objects/pack/pack-2ae90a5428c30ca4ce86d2e16f73c6c5f54b66b5.idx
error: wrong index v2 file size in /Users/servo/buildbot/slave/mac-dev-unit/build/.git/objects/pack/pack-2ae90a5428c30ca4ce86d2e16f73c6c5f54b66b5.idx
error: wrong index v2 file size in /Users/servo/buildbot/slave/mac-dev-unit/build/.git/objects/pack/pack-2ae90a5428c30ca4ce86d2e16f73c6c5f54b66b5.idx
error: wrong index v2 file size in /Users/servo/buildbot/slave/mac-dev-unit/build/.git/objects/pack/pack-2ae90a5428c30ca4ce86d2e16f73c6c5f54b66b5.idx
error: wrong index v2 file size in /Users/servo/buildbot/slave/mac-dev-unit/build/.git/objects/pack/pack-2ae90a5428c30ca4ce86d2e16f73c6c5f54b66b5.idx
fatal: bad object c416b33345c2923f569f3f78604fbf512b85857e
error: wrong index v2 file size in /Users/servo/buildbot/slave/mac-dev-unit/build/.git/objects/pack/pack-2ae90a5428c30ca4ce86d2e16f73c6c5f54b66b5.idx
fatal: remote did not send all necessary objects

Looks like it needs an fsck.
@Manishearth
Copy link
Member

Manishearth commented Feb 14, 2016

@larsbergstrom It seems like the mac password has changed, could you run a git fsck on servo-mac1 when you get the chance?
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Feb 14, 2016

@Manishearth Directory is empty.

Also, the updated password is in the "seekrits" google doc. You should be able to ssh in as root@. There's been a bit of back-and-forth on the salt side about whether we should ssh in as root@ or administrator@ to the macs. After the next highstate, all macs should be administrator@ again.
@Manishearth
Copy link
Member

Manishearth commented Feb 14, 2016

@bors retry

Nah, it needed an fsck in the git dir for that builder.

root@ fixed it. I don't think I have access to seekrits though. Thanks!
@KiChjang
Copy link
Member

KiChjang commented Feb 15, 2016

@Manishearth THIS. IS. SERVO!!!!!!

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2016

⌛ Testing commit 8fa82f6 with merge c9b2ef5...
bors-servo added a commit that referenced this pull request Feb 15, 2016
@bors-servo
Auto merge of #9634 - craftytrickster:issue/9564, r=Manishearth
Loading status checks…
c9b2ef5 
Adding warning to properties.mako.rs regarding the Mako parser mangling

#9564 (comment)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9634)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2016

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Feb 15, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-unit are reusable. Rebuilding only linux-rel, mac-rel-css, mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member

KiChjang commented Feb 15, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-unit, mac-rel-css are reusable. Rebuilding only linux-rel, mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 8fa82f6 into servo:master Feb 15, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@craftytrickster @highfive @Manishearth @bors-servo @larsbergstrom @KiChjang @jdm
You can’t perform that action at this time.