Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9640 Refactor: Move util::str::is_token to script::dom::bindings::str #9642

Merged
merged 1 commit into from Feb 15, 2016
Merged

#9640 Refactor: Move util::str::is_token to script::dom::bindings::str #9642

merged 1 commit into from Feb 15, 2016

Conversation

@peterjoel
Copy link
Contributor

peterjoel commented Feb 14, 2016

Review on Reviewable
@peterjoel
#9640 Refactor: Move util::str::is_token to script::dom::bindings::str
Loading status checks…
f374e8f
@highfive
Copy link

highfive commented Feb 14, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Ms2ger (or someone else) soon.
@highfive
Copy link

highfive commented Feb 14, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@nox
Copy link
Member

nox commented Feb 14, 2016

@bors-servo r+

Thanks for your contribution!
@bors-servo
Copy link
Contributor

bors-servo commented Feb 14, 2016

📌 Commit f374e8f has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Feb 14, 2016

⌛ Testing commit f374e8f with merge 4f07aa7...
bors-servo added a commit that referenced this pull request Feb 14, 2016
@bors-servo
Auto merge of #9642 - peterjoel:issue_9640_move_util_str_is_token, r=nox
Loading status checks…
4f07aa7 
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9642)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 14, 2016

💔 Test failed - linux-rel
@nox
Copy link
Member

nox commented Feb 15, 2016

@bors-servo retry #8127 #8191
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit f374e8f into servo:master Feb 15, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@KiChjang KiChjang mentioned this pull request Feb 15, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@peterjoel @highfive @nox @bors-servo
You can’t perform that action at this time.