Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the hasInstance hook of interface objects #9645

Merged
merged 2 commits into from Feb 15, 2016
Merged

Fix the hasInstance hook of interface objects #9645

merged 2 commits into from Feb 15, 2016

Conversation

@nox
Copy link
Member

nox commented Feb 15, 2016

Review on Reviewable
@nox
Clean up imports in script::dom::bindings::interface
e08f817
@highfive
Copy link

highfive commented Feb 15, 2016

warning Warning warning

  • This pull request adds a file without the .ini file extension to tests/wpt/mozilla/meta. Please consider removing it!
  • These commits modify unsafe code. Please review it carefully!
@Ms2ger
Copy link
Contributor

Ms2ger commented Feb 15, 2016

-S-awaiting-review +S-needs-code-changes

Reviewed 1 of 1 files at r1, 3 of 3 files at r2.
Review status: all files reviewed at latest revision, 5 unresolved discussions.

components/script/dom/bindings/interface.rs, line 264 [r2] (raw file):
interface_object

components/script/dom/bindings/interface.rs, line 286 [r2] (raw file):
I think this is guaranteed to be the interface prototype object, which we cache, so that might be an easier way to get hold of the object.

tests/wpt/mozilla/tests/mozilla/has-instance.html, line 1 [r2] (raw file):
Why not upstream?

tests/wpt/mozilla/tests/mozilla/has-instance.html, line 8 [r2] (raw file):
I think Object.create() is the preferred approach.

tests/wpt/mozilla/tests/mozilla/has-instance.html, line 9 [r2] (raw file):
Also test Element.

Comments from the review on Reviewable.io
@nox nox force-pushed the nox:fix-has-instance branch from cd4c2cc to ca0a957 Feb 15, 2016
@nox
Copy link
Member Author

nox commented Feb 15, 2016

Review status: 0 of 3 files reviewed at latest revision, 5 unresolved discussions.

components/script/dom/bindings/interface.rs, line 286 [r2] (raw file):
Done.

tests/wpt/web-platform-tests/WebIDL/ecmascript-binding/has-instance.html, line 1 [r2] (raw file):
Done.

tests/wpt/web-platform-tests/WebIDL/ecmascript-binding/has-instance.html, line 8 [r2] (raw file):
Done.

tests/wpt/web-platform-tests/WebIDL/ecmascript-binding/has-instance.html, line 9 [r2] (raw file):
Done.

Comments from the review on Reviewable.io
@Ms2ger
Copy link
Contributor

Ms2ger commented Feb 15, 2016

-S-awaiting-review +S-needs-code-changes

Reviewed 5 of 5 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

components/script/dom/bindings/interface.rs, line 286 [r3] (raw file):
I would prefer not to use from_marked_location here; this code is not hot enough to warrant it.

Comments from the review on Reviewable.io
@nox
Fix the hasInstance hook of interface objects
Loading status checks…
ae72d1d 
Step 2 wasn't properly implemented.
@nox nox force-pushed the nox:fix-has-instance branch from ca0a957 to ae72d1d Feb 15, 2016
@nox
Copy link
Member Author

nox commented Feb 15, 2016

Review status: 2 of 3 files reviewed at latest revision, 1 unresolved discussion.

components/script/dom/bindings/interface.rs, line 286 [r3] (raw file):
Done.

Comments from the review on Reviewable.io
@Ms2ger
Copy link
Contributor

Ms2ger commented Feb 15, 2016

@bors-servo r+

Reviewed 1 of 1 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2016

📌 Commit ae72d1d has been approved by Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2016

⌛ Testing commit ae72d1d with merge 87c6889...
bors-servo added a commit that referenced this pull request Feb 15, 2016
@bors-servo
Auto merge of #9645 - nox:fix-has-instance, r=Ms2ger
Loading status checks…
87c6889 
Fix the hasInstance hook of interface objects

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9645)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2016

💔 Test failed - mac-rel-css
@nox
Copy link
Member Author

nox commented Feb 15, 2016

@bors-servo retry #7791
@nox nox removed the S-tests-failed label Feb 15, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-unit, mac-rel-wpt are reusable. Rebuilding only linux-rel, mac-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit ae72d1d into servo:master Feb 15, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Feb 15, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ms2ger Ms2ger

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@nox @highfive @Ms2ger @bors-servo
You can’t perform that action at this time.