Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate CSS tests to revision f3fcc824c64126b77c8c9856e89989b66c3a7e5d #9656
Conversation
highfive
commented
Feb 16, 2016
|
Why disable the manifest check? |
|
@bors-servo: r+ |
|
|
Update CSS tests to revision f3fcc824c64126b77c8c9856e89989b66c3a7e5d <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9656) <!-- Reviewable:end -->
|
|
|
@bors-servo r=jdm |
|
|
Update CSS tests to revision f3fcc824c64126b77c8c9856e89989b66c3a7e5d <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9656) <!-- Reviewable:end -->
|
@bors-servo retry |
|
|
Update CSS tests to revision f3fcc824c64126b77c8c9856e89989b66c3a7e5d <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9656) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry
|
Update CSS tests to revision f3fcc824c64126b77c8c9856e89989b66c3a7e5d <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9656) <!-- Reviewable:end -->
|
|
|
|
I suspect the issue here is that we split a two-byte sequence into separate chunks when parsing; #9677 might fix that. |
|
@Ms2ger What do you want to do here? |
|
I was hoping #9730 would go through. I suppose I'll just have to disable a bunch of these tests. |
|
Ok, I'll take a look at the new revisions there and we can hold off making a decision here for a bit longer. |
|
Nevermind, I misinterpreted the status there. |
|
|
Ms2ger commentedFeb 16, 2016