Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CSS tests to revision f3fcc824c64126b77c8c9856e89989b66c3a7e5d #9656

Closed
wants to merge 2 commits into from

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Feb 16, 2016

Review on Reviewable

@highfive
Copy link

highfive commented Feb 16, 2016

warning Warning warning

  • This pull request adds a file without the .ini file extension to tests/wpt/metadata. Please consider removing it!
  • This pull request modifies the contents of
    'tests/wpt/css-tests/', which are overwriten occasionally whenever the
    directory is synced from upstream.
@jdm
Copy link
Member

jdm commented Feb 16, 2016

Why disable the manifest check?

@jdm
Copy link
Member

jdm commented Feb 16, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Feb 16, 2016

📌 Commit 37da25c has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Feb 16, 2016

Testing commit 37da25c with merge 30028d0...

bors-servo added a commit that referenced this pull request Feb 16, 2016
Update CSS tests to revision f3fcc824c64126b77c8c9856e89989b66c3a7e5d

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9656)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 16, 2016

💔 Test failed - linux-rel

@Ms2ger Ms2ger force-pushed the update-css branch from 37da25c to ad71311 Feb 16, 2016
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Feb 16, 2016

@bors-servo r=jdm

@bors-servo
Copy link
Contributor

bors-servo commented Feb 16, 2016

📌 Commit ad71311 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Feb 16, 2016

Testing commit ad71311 with merge 51826df...

bors-servo added a commit that referenced this pull request Feb 16, 2016
Update CSS tests to revision f3fcc824c64126b77c8c9856e89989b66c3a7e5d

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9656)
<!-- Reviewable:end -->
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Feb 16, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Feb 16, 2016

Testing commit ad71311 with merge 733962d...

bors-servo added a commit that referenced this pull request Feb 16, 2016
Update CSS tests to revision f3fcc824c64126b77c8c9856e89989b66c3a7e5d

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9656)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 16, 2016

💔 Test failed - mac-rel-css

@jdm
Copy link
Member

jdm commented Feb 16, 2016

@bors-servo: retry

  • service interruption
@bors-servo
Copy link
Contributor

bors-servo commented Feb 16, 2016

Testing commit ad71311 with merge 40fffac...

bors-servo added a commit that referenced this pull request Feb 16, 2016
Update CSS tests to revision f3fcc824c64126b77c8c9856e89989b66c3a7e5d

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9656)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 16, 2016

💔 Test failed - mac-rel-css

@jdm
Copy link
Member

jdm commented Feb 17, 2016

  ▶ FAIL [expected PASS] /css-text-3_dev/html/text-transform-capitalize-014.htm
  └   → /css-text-3_dev/html/text-transform-capitalize-014.htm b89dfd66ef20553565f4e7f15bcbe42a1506735d
/css-text-3_dev/html/reference/text-transform-capitalize-014-ref.htm 3f3f18282cb8d48a862cd4d688f3150718c0cd00
Testing b89dfd66ef20553565f4e7f15bcbe42a1506735d == 3f3f18282cb8d48a862cd4d688f3150718c0cd00

  ▶ FAIL [expected PASS] /css-text-3_dev/html/text-transform-capitalize-018.htm
  └   → /css-text-3_dev/html/text-transform-capitalize-018.htm dcb3176c253bec002e4cd2db1abfe023ee6614bb
/css-text-3_dev/html/reference/text-transform-capitalize-018-ref.htm 01f68d78f3c9a36b162a6a3cd413f2d554667ff3
Testing dcb3176c253bec002e4cd2db1abfe023ee6614bb == 01f68d78f3c9a36b162a6a3cd413f2d554667ff3

  ▶ FAIL [expected PASS] /css-text-3_dev/html/text-transform-upperlower-028.htm
  └   → /css-text-3_dev/html/text-transform-upperlower-028.htm 2295aaf97e437eaa0597710d73d44031c856cf2e
/css-text-3_dev/html/reference/text-transform-upperlower-028-ref.htm e66da2b1666362ae5f5e3de7924034254a428890
Testing 2295aaf97e437eaa0597710d73d44031c856cf2e == e66da2b1666362ae5f5e3de7924034254a428890

  ▶ FAIL [expected PASS] /css-text-3_dev/html/text-transform-upperlower-029.htm
  └   → /css-text-3_dev/html/text-transform-upperlower-029.htm 699aaf30767f8c6e4f1c5fba3b4e3cd32019cb8d
/css-text-3_dev/html/reference/text-transform-upperlower-029-ref.htm 33921958affd6eaebd40b3a5f194a5d9cc23baf0
Testing 699aaf30767f8c6e4f1c5fba3b4e3cd32019cb8d == 33921958affd6eaebd40b3a5f194a5d9cc23baf0

  ▶ FAIL [expected PASS] /css-text-3_dev/html/text-transform-upperlower-101.htm
  └   → /css-text-3_dev/html/text-transform-upperlower-101.htm 7e02b9c673b825c190ef0977e303ea3642fce4e5
/css-text-3_dev/html/reference/text-transform-upperlower-101-ref.htm 5935d324f2966d4343d96d0bb83166544a489c08
Testing 7e02b9c673b825c190ef0977e303ea3642fce4e5 == 5935d324f2966d4343d96d0bb83166544a489c08
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Feb 18, 2016

I suspect the issue here is that we split a two-byte sequence into separate chunks when parsing; #9677 might fix that.

@jdm
Copy link
Member

jdm commented Feb 26, 2016

@Ms2ger What do you want to do here?

@Ms2ger
Copy link
Contributor Author

Ms2ger commented Feb 26, 2016

I was hoping #9730 would go through. I suppose I'll just have to disable a bunch of these tests.

@jdm
Copy link
Member

jdm commented Feb 26, 2016

Ok, I'll take a look at the new revisions there and we can hold off making a decision here for a bit longer.

@jdm jdm removed the S-awaiting-answer label Feb 26, 2016
@jdm jdm self-assigned this Feb 26, 2016
@jdm
Copy link
Member

jdm commented Feb 26, 2016

Nevermind, I misinterpreted the status there.

@bors-servo
Copy link
Contributor

bors-servo commented Feb 29, 2016

The latest upstream changes (presumably #8932) made this pull request unmergeable. Please resolve the merge conflicts.

@Ms2ger Ms2ger closed this Mar 2, 2016
@Ms2ger Ms2ger deleted the update-css branch Mar 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.