Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid some spurious string copies in XHR. #9700

Merged
merged 1 commit into from Feb 19, 2016
Merged

Avoid some spurious string copies in XHR. #9700

merged 1 commit into from Feb 19, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Feb 19, 2016

Review on Reviewable
@Ms2ger
Avoid some spurious string copies in XHR.
Loading status checks…
18e6a63
@highfive
Copy link

highfive commented Feb 19, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@KiChjang KiChjang self-assigned this Feb 19, 2016
@KiChjang
Copy link
Member

KiChjang commented Feb 19, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 19, 2016

📌 Commit 18e6a63 has been approved by KiChjang
@bors-servo
Copy link
Contributor

bors-servo commented Feb 19, 2016

⌛ Testing commit 18e6a63 with merge 3a0a70f...
bors-servo added a commit that referenced this pull request Feb 19, 2016
@bors-servo
Auto merge of #9700 - servo:xhr-to-owned, r=KiChjang
3a0a70f 
Avoid some spurious string copies in XHR.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9700)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 19, 2016

💔 Test failed - mac-rel-wpt
@KiChjang
Copy link
Member

KiChjang commented Feb 19, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 19, 2016

⌛ Testing commit 18e6a63 with merge 94d28bf...
bors-servo added a commit that referenced this pull request Feb 19, 2016
@bors-servo
Auto merge of #9700 - servo:xhr-to-owned, r=KiChjang
Loading status checks…
94d28bf 
Avoid some spurious string copies in XHR.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9700)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 19, 2016

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Feb 19, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 19, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 19, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 18e6a63 into master Feb 19, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@nox nox deleted the xhr-to-owned branch Feb 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KiChjang KiChjang

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @highfive @KiChjang @bors-servo @jdm
You can’t perform that action at this time.