Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add instructions for OpenSSL on OS X 10.11 #9703

Merged
merged 1 commit into from Feb 19, 2016
Merged

Add instructions for OpenSSL on OS X 10.11 #9703

merged 1 commit into from Feb 19, 2016

Conversation

@djc
Copy link
Contributor

@djc djc commented Feb 19, 2016

See #7930.

Review on Reviewable
@highfive
Copy link

@highfive highfive commented Feb 19, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @SimonSapin (or someone else) soon.
@larsbergstrom
Copy link
Contributor

@larsbergstrom larsbergstrom commented Feb 19, 2016

I thought that if we did the link --force, things would compile, and that the INCLUDE_DIR stuff was only needed if you don't want to forcibly link all of the openssl headers & libs into global locations. Do you know?
@larsbergstrom larsbergstrom self-assigned this Feb 19, 2016
@djc
Add instructions for OpenSSL on OS X 10.11
a0458b7 
See #7930.
@djc djc force-pushed the djc:patch-1 branch from a928ce9 to a0458b7 Feb 19, 2016
@djc
Copy link
Contributor Author

@djc djc commented Feb 19, 2016

Yeah, I guess if you start from scratch this works. (Previously I only ran into the failure halfway through the build, and the advice to run cargo clean didn't work; I only discovered ./mach clean later.)

Patch updated.
@larsbergstrom
Copy link
Contributor

@larsbergstrom larsbergstrom commented Feb 19, 2016

Excellent - thanks for the PR and for the quick fix!
@larsbergstrom
Copy link
Contributor

@larsbergstrom larsbergstrom commented Feb 19, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented Feb 19, 2016

📌 Commit a0458b7 has been approved by larsbergstrom
@vladikoff
Copy link

@vladikoff vladikoff commented Feb 19, 2016

Thanks for this!
@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented Feb 19, 2016

⌛ Testing commit a0458b7 with merge ff20a2d...
bors-servo added a commit that referenced this pull request Feb 19, 2016
@bors-servo
Auto merge of #9703 - djc:patch-1, r=larsbergstrom
ff20a2d 
Add instructions for OpenSSL on OS X 10.11

See #7930.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9703)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented Feb 19, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit a0458b7 into servo:master Feb 19, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bors-servo
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@larsbergstrom larsbergstrom

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@djc @highfive @larsbergstrom @bors-servo @vladikoff