Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Documents' browsing contexts. #9714

Merged
merged 2 commits into from Feb 21, 2016
Merged

Improvements to Documents' browsing contexts. #9714

merged 2 commits into from Feb 21, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Feb 20, 2016

Review on Reviewable
jdm added 2 commits Nov 23, 2015
@jdm @Ms2ger
Make it possible for XMLDocuments to have a browsing context.
7045056
@jdm @Ms2ger
Use the browsing context from the document where appropriate.
Loading status checks…
f5b5079 
This should not change behaviour.
@highfive
Copy link

highfive commented Feb 20, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@nox
Copy link
Member

nox commented Feb 20, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 20, 2016

📌 Commit f5b5079 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Feb 20, 2016

⌛ Testing commit f5b5079 with merge 9f9eaad...
@nox nox self-assigned this Feb 20, 2016
bors-servo added a commit that referenced this pull request Feb 20, 2016
@bors-servo
Auto merge of #9714 - servo:browsingcontext, r=nox
9f9eaad 
Improvements to Documents' browsing contexts.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9714)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 20, 2016

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Feb 20, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 20, 2016

⌛ Testing commit f5b5079 with merge f5193eb...
bors-servo added a commit that referenced this pull request Feb 20, 2016
@bors-servo
Auto merge of #9714 - servo:browsingcontext, r=nox
Loading status checks…
f5193eb 
Improvements to Documents' browsing contexts.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9714)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 20, 2016

💔 Test failed - mac-rel-wpt
@KiChjang
Copy link
Member

KiChjang commented Feb 20, 2016

@bors-servo retry

  • git problem
@bors-servo
Copy link
Contributor

bors-servo commented Feb 20, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-unit are reusable. Rebuilding only linux-rel, mac-rel-css, mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 20, 2016

💔 Test failed - mac-rel-wpt
@KiChjang
Copy link
Member

KiChjang commented Feb 20, 2016

@bors-servo retry

  • Infrastructure problem
@bors-servo
Copy link
Contributor

bors-servo commented Feb 20, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-unit are reusable. Rebuilding only linux-rel, mac-rel-css, mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 20, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member

KiChjang commented Feb 20, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 20, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-unit, mac-rel-css are reusable. Rebuilding only linux-rel, mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 21, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member

KiChjang commented Feb 21, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 21, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 21, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member

KiChjang commented Feb 21, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 21, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 21, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit f5b5079 into master Feb 21, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@nox nox deleted the browsingcontext branch Feb 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@Ms2ger @highfive @nox @bors-servo @jdm @KiChjang
You can’t perform that action at this time.