Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support syncing from a clean tree. #9718

Merged
merged 1 commit into from Feb 26, 2016
Merged

Support syncing from a clean tree. #9718

merged 1 commit into from Feb 26, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Feb 22, 2016

Review on Reviewable
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Feb 22, 2016

r? @jgraham
@jgraham
Copy link
Contributor

jgraham commented Feb 22, 2016

Review status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions.

tests/wpt/update/update.py, line 21 [r1] (raw file):
Should perhaps only create this if we are actually going to do a sync rather than just a metadata update.

tests/wpt/update/update.py, line 41 [r1] (raw file):
This is already done in SyncFromUpstream; why did you add it here?

Comments from the review on Reviewable.io
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Feb 22, 2016

Review status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions.

tests/wpt/update/update.py, line 41 [r1] (raw file):
Because that's too late; SyncToUpstream tries to import some things from within the sync repo.

Comments from the review on Reviewable.io
@Ms2ger
Include UpdateCheckout in SyncToUpstreamRunner.
Loading status checks…
070d3ff 
This is necessary to support syncing from a clean tree.
@Ms2ger Ms2ger force-pushed the Ms2ger:clean-sync branch from 8a903f4 to 070d3ff Feb 26, 2016
@jgraham
Copy link
Contributor

jgraham commented Feb 26, 2016

Reviewed 2 of 3 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Feb 26, 2016

@bors-servo r=jgraham

Over IRC
@bors-servo
Copy link
Contributor

bors-servo commented Feb 26, 2016

📌 Commit 070d3ff has been approved by jgraham
@bors-servo
Copy link
Contributor

bors-servo commented Feb 26, 2016

⌛ Testing commit 070d3ff with merge 1d2e6a2...
bors-servo added a commit that referenced this pull request Feb 26, 2016
@bors-servo
Auto merge of #9718 - Ms2ger:clean-sync, r=jgraham
1d2e6a2 
Support syncing from a clean tree.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9718)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 26, 2016

💔 Test failed - linux-rel
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Feb 26, 2016

@bors-servo retry
#9014
@bors-servo
Copy link
Contributor

bors-servo commented Feb 26, 2016

⌛ Testing commit 070d3ff with merge 0670e00...
bors-servo added a commit that referenced this pull request Feb 26, 2016
@bors-servo
Auto merge of #9718 - Ms2ger:clean-sync, r=jgraham
0670e00 
Support syncing from a clean tree.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9718)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 26, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member

KiChjang commented Feb 26, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 26, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 26, 2016

💔 Test failed - linux-rel
@nox
Copy link
Member

nox commented Feb 26, 2016

@bors-servo retry #9278
@nox nox added S-awaiting-merge and removed S-tests-failed labels Feb 26, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Feb 26, 2016

⌛ Testing commit 070d3ff with merge d424bd1...
bors-servo added a commit that referenced this pull request Feb 26, 2016
@bors-servo
Auto merge of #9718 - Ms2ger:clean-sync, r=jgraham
Loading status checks…
d424bd1 
Support syncing from a clean tree.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9718)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 26, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 070d3ff into servo:master Feb 26, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the Ms2ger:clean-sync branch Mar 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jgraham jgraham

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@Ms2ger @jgraham @bors-servo @KiChjang @nox @highfive
You can’t perform that action at this time.