Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBump to Rust 2016-02-22 #9721
Bump to Rust 2016-02-22 #9721
Conversation
highfive
commented
Feb 22, 2016
|
I'm fine with everything except for the geckolib lockfile changes, which I assume @bholley will want to review, since they add more crates to the dependency graph. Reviewed 10 of 11 files at r1. Comments from the review on Reviewable.io |
|
@larsbergstrom These new dependencies are due to heapsize’s build script using the regex crate. It’s a dev-dependency, it should not affect the size of the compiled binaries. |
|
@SimonSapin That's certainly true, but it would affect the number of crates that would have to be vendor into m-c if we move forward with Stylo. Not saying that matters - just that I don't know :-) |
|
If it’s a problem I can rewrite that build script to not use regex. I’ve only used it to extract |
|
I care a lot about staticlib size, not so much about the amount of code that we'd need to vendor (since I'm in favoring of vendoring all of Servo anyway). If it's actually the case that these changes don't affect the final binary, I'm fine with it. |
|
@bors-servo r+ |
|
|
|
|
Bump to Rust 2016-02-22 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9721) <!-- Reviewable:end -->
|
|
|
Added a fix for gonk. r? |
|
@bors-servo r=larsbergstrom,nox |
|
|
Bump to Rust 2016-02-22 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9721) <!-- Reviewable:end -->
|
|
|
|
|
|
|
@bors-servo r=larsbergstrom,nox Unprefixed je_mallctl except on Android and OS X, like je_malloc_usable_size in heapsize. |
|
|
Bump to Rust 2016-02-22 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9721) <!-- Reviewable:end -->
|
|
|
@bors-servo retry Git snafu. |
|
|
|
|
|
Weird. Pipeline missing intermittent is shifting around with the removal of other intermittents, perhaps?
|
|
|
|
@bors-servo retry #9723 #9724 |
|
|
|
|
nox commentedFeb 22, 2016