Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upStop returning an Option from Window::browsing_context. #9729
Conversation
A Window always has a WindowProxy; the only reason it's wrapped in a nullable field is the order in which those objects are created.
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 23, 2016
Stop returning an Option from Window::browsing_context. A Window always has a WindowProxy; the only reason it's wrapped in a nullable field is the order in which those objects are created. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9729) <!-- Reviewable:end -->
|
|
|
@bors-servo retry
|
bors-servo
added a commit
that referenced
this pull request
Feb 23, 2016
Stop returning an Option from Window::browsing_context. A Window always has a WindowProxy; the only reason it's wrapped in a nullable field is the order in which those objects are created. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9729) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Ms2ger commentedFeb 23, 2016
A Window always has a WindowProxy; the only reason it's wrapped in a nullable
field is the order in which those objects are created.