Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Browser API event mozbrowserconnected #9740

Merged
merged 1 commit into from Feb 25, 2016
Merged

Support Browser API event mozbrowserconnected #9740

merged 1 commit into from Feb 25, 2016

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Feb 24, 2016

Fixes #9382

This new event is not yet documented. If this lands, I will add documentation to MDN.

Review on Reviewable
@highfive
Copy link

highfive commented Feb 24, 2016

warning Warning warning

  • This pull request adds a file without the .ini file extension to tests/wpt/mozilla/meta. Please consider removing it!
@paulrouget
Copy link
Contributor Author

paulrouget commented Feb 24, 2016

This pull request adds a file without the .ini file extension to tests/wpt/mozilla/meta. Please consider removing it!

I don't understand.
@KiChjang
Copy link
Member

KiChjang commented Feb 24, 2016

False positive. Currently highfive doesn't know that MANIFEST.json can be ignored. There's an ongoing PR that fixes this in servo/highfive#62.
@jdm
Copy link
Member

jdm commented Feb 24, 2016

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 24, 2016

📌 Commit fc80de8 has been approved by jdm
@jdm
Copy link
Member

jdm commented Feb 24, 2016

@bors-servo: r-
@jdm
Copy link
Member

jdm commented Feb 24, 2016 

176.40s$ bash etc/ci/manifest_changed.sh
diff --git a/tests/wpt/mozilla/meta/MANIFEST.json b/tests/wpt/mozilla/meta/MANIFEST.json
index bf051fe..b12f912 100644
--- a/tests/wpt/mozilla/meta/MANIFEST.json
+++ b/tests/wpt/mozilla/meta/MANIFEST.json
@@ -5928,18 +5928,18 @@
             "url": "/_mozilla/mozilla/mozbrowser/iframe_goback.html"
           }
         ],
-        "mozilla/mozbrowser/mozbrowser_loadevents.html": [
-          {
-            "path": "mozilla/mozbrowser/mozbrowser_loadevents.html",
-            "url": "/_mozilla/mozilla/mozbrowser/mozbrowser_loadevents.html"
-          }
-        ],
         "mozilla/mozbrowser/iframe_reload_twice.html": [
           {
             "path": "mozilla/mozbrowser/iframe_reload_twice.html",
             "url": "/_mozilla/mozilla/mozbrowser/iframe_reload_twice.html"
           }
         ],
+        "mozilla/mozbrowser/mozbrowser_loadevents.html": [
+          {
+            "path": "mozilla/mozbrowser/mozbrowser_loadevents.html",
+            "url": "/_mozilla/mozilla/mozbrowser/mozbrowser_loadevents.html"
+          }
+        ],
         "mozilla/mozbrowser/mozbrowsericonchange_event.html": [
           {
             "path": "mozilla/mozbrowser/mozbrowsericonchange_event.html",
@jdm jdm self-assigned this Feb 24, 2016
@jdm
Copy link
Member

jdm commented Feb 24, 2016

@bors-servo: delegate+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 24, 2016

✌️ @paulrouget can now approve this pull request
@paulrouget
Support Browser API event mozbrowserconnected
Loading status checks…
3ecc907
@paulrouget paulrouget force-pushed the paulrouget:mozbrowserconnected branch from fc80de8 to 3ecc907 Feb 24, 2016
@paulrouget
Copy link
Contributor Author

paulrouget commented Feb 24, 2016

@bors-servo: r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Feb 24, 2016

📌 Commit 3ecc907 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Feb 25, 2016

⌛ Testing commit 3ecc907 with merge 442b890...
bors-servo added a commit that referenced this pull request Feb 25, 2016
@bors-servo
Auto merge of #9740 - paulrouget:mozbrowserconnected, r=jdm
442b890 
Support Browser API event mozbrowserconnected

Fixes #9382

This new event is not yet documented. If this lands, I will add documentation to MDN.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9740)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 25, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member

KiChjang commented Feb 25, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 25, 2016

⌛ Testing commit 3ecc907 with merge 42f1712...
bors-servo added a commit that referenced this pull request Feb 25, 2016
@bors-servo
Auto merge of #9740 - paulrouget:mozbrowserconnected, r=jdm
Loading status checks…
42f1712 
Support Browser API event mozbrowserconnected

Fixes #9382

This new event is not yet documented. If this lands, I will add documentation to MDN.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9740)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 25, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 3ecc907 into servo:master Feb 25, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@paulrouget @highfive @KiChjang @jdm @bors-servo
You can’t perform that action at this time.