Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of From<String> for Atom #9742

Merged
merged 5 commits into from Feb 25, 2016
Merged

Make use of From<String> for Atom #9742

merged 5 commits into from Feb 25, 2016

Conversation

@nox
Copy link
Member

nox commented Feb 24, 2016

Review on Reviewable
nox added 5 commits Feb 24, 2016
@nox
Bump string_cache to 0.2.10
50af73d
@nox
Make use of From<String> for Atom
cc030df
@nox
Use atom!("error") in EventTarget::get_compiled_event_handler
25ae4ed
@nox
Optimise local name cloning in Document::CreateAttribute
f7fb035
@nox
Implement From<DOMString> for Atom
Loading status checks…
0adfb08
@highfive
Copy link

highfive commented Feb 24, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/Cargo.toml, components/style/properties.mako.rs, components/style/attr.rs, components/style/stylesheets.rs
  • @ecoal95: components/script/dom/webglcontextevent.rs
@Ms2ger
Copy link
Contributor

Ms2ger commented Feb 24, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 24, 2016

📌 Commit 0adfb08 has been approved by Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Feb 24, 2016

⌛ Testing commit 0adfb08 with merge 9943958...
bors-servo added a commit that referenced this pull request Feb 24, 2016
@bors-servo
Auto merge of #9742 - nox:atom-from-string, r=Ms2ger
9943958 
Make use of From<String> for Atom

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9742)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 24, 2016

💔 Test failed - linux-rel
@emilio
Copy link
Member

emilio commented Feb 24, 2016

@bors-servo: retry
@emilio
Copy link
Member

emilio commented Feb 24, 2016

@bors-servo: r+ (?)
@bors-servo
Copy link
Contributor

bors-servo commented Feb 24, 2016

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #9743
@bors-servo
Copy link
Contributor

bors-servo commented Feb 24, 2016

📌 Commit 0adfb08 has been approved by ecoal95
@bors-servo
Copy link
Contributor

bors-servo commented Feb 25, 2016

⌛ Testing commit 0adfb08 with merge b3b6f09...
bors-servo added a commit that referenced this pull request Feb 25, 2016
@bors-servo
Auto merge of #9742 - nox:atom-from-string, r=ecoal95
Loading status checks…
b3b6f09 
Make use of From<String> for Atom

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9742)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 25, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 0adfb08 into servo:master Feb 25, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@nox @highfive @Ms2ger @bors-servo @emilio @SimonSapin
You can’t perform that action at this time.