Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use return value of invoking event handlers to cancel the event #9755

Merged
merged 1 commit into from Feb 27, 2016
Merged

use return value of invoking event handlers to cancel the event #9755

merged 1 commit into from Feb 27, 2016

Conversation

@jdm
Copy link
Member

jdm commented Feb 25, 2016

Rebased from #8707. Fixes #8490. We can modify the code and test as necessary whenever we make a decision about whatwg/html#423 in the future.

Review on Reviewable
@highfive
Copy link

highfive commented Feb 25, 2016

warning Warning warning

  • This pull request adds a file without the .ini file extension to tests/wpt/metadata. Please consider removing it!
@jdm
Copy link
Member Author

jdm commented Feb 25, 2016

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 25, 2016

📌 Commit ae52b40 has been approved by jdm
@jdm jdm assigned jdm and unassigned nox Feb 25, 2016
@jdm jdm mentioned this pull request Feb 25, 2016
Closed
@bors-servo
Copy link
Contributor

bors-servo commented Feb 25, 2016

⌛ Testing commit ae52b40 with merge 04c646f...
bors-servo added a commit that referenced this pull request Feb 25, 2016
@bors-servo
Auto merge of #9755 - jdm:handlerreturn, r=jdm
04c646f 
use return value of invoking event handlers to cancel the event

Rebased from #8707. Fixes #8490. We can modify the code and test as necessary whenever we make a decision about whatwg/html#423 in the future.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9755)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 25, 2016

💔 Test failed - linux-dev
@KiChjang
Copy link
Member

KiChjang commented Feb 25, 2016 

diff --git a/tests/wpt/metadata/MANIFEST.json b/tests/wpt/metadata/MANIFEST.json
index ae25606..096e9ac 100644
--- a/tests/wpt/metadata/MANIFEST.json
+++ b/tests/wpt/metadata/MANIFEST.json
@@ -39862,17 +39862,17 @@
         ]
       },
       "testharness": {
-        "html/webappapis/scripting/events/event-handler-processing-algorithm.html": [
-          {
-            "path": "html/webappapis/scripting/events/event-handler-processing-algorithm.html",
-            "url": "/html/webappapis/scripting/events/event-handler-processing-algorithm.html"
-          }
-        ],
         "WebIDL/ecmascript-binding/interface-object.html": [
           {
             "path": "WebIDL/ecmascript-binding/interface-object.html",
             "url": "/WebIDL/ecmascript-binding/interface-object.html"
           }
+        ],
+        "html/webappapis/scripting/events/event-handler-processing-algorithm.html": [
+          {
+            "path": "html/webappapis/scripting/events/event-handler-processing-algorithm.html",
+            "url": "/html/webappapis/scripting/events/event-handler-processing-algorithm.html"
+          }
         ]
       }
     },
@jdm jdm force-pushed the jdm:handlerreturn branch from ae52b40 to cf0f0b4 Feb 25, 2016
@Ms2ger
Copy link
Contributor

Ms2ger commented Feb 26, 2016

@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Feb 26, 2016

📌 Commit cf0f0b4 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Feb 26, 2016

☔ The latest upstream changes (presumably #9747) made this pull request unmergeable. Please resolve the merge conflicts.
@Ms2ger Ms2ger force-pushed the jdm:handlerreturn branch from cf0f0b4 to 2005711 Feb 26, 2016
@Ms2ger
Copy link
Contributor

Ms2ger commented Feb 26, 2016

@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Feb 26, 2016

📌 Commit 2005711 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Feb 26, 2016

⌛ Testing commit 2005711 with merge 8fc53b2...
bors-servo added a commit that referenced this pull request Feb 26, 2016
@bors-servo
Auto merge of #9755 - jdm:handlerreturn, r=jdm
8fc53b2 
use return value of invoking event handlers to cancel the event

Rebased from #8707. Fixes #8490. We can modify the code and test as necessary whenever we make a decision about whatwg/html#423 in the future.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9755)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 26, 2016

💔 Test failed - linux-rel
@jxs @jdm
use return value of invoking event handlers to cancel the event
Loading status checks…
b60d668
@jdm jdm force-pushed the jdm:handlerreturn branch from 2005711 to b60d668 Feb 26, 2016
@jdm
Copy link
Member Author

jdm commented Feb 26, 2016

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 26, 2016

📌 Commit b60d668 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Feb 27, 2016

⌛ Testing commit b60d668 with merge 8bdffa2...
bors-servo added a commit that referenced this pull request Feb 27, 2016
@bors-servo
Auto merge of #9755 - jdm:handlerreturn, r=jdm
Loading status checks…
8bdffa2 
use return value of invoking event handlers to cancel the event

Rebased from #8707. Fixes #8490. We can modify the code and test as necessary whenever we make a decision about whatwg/html#423 in the future.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9755)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 27, 2016

💔 Test failed - mac-rel-wpt
@nox
Copy link
Member

nox commented Feb 27, 2016

@bors-servo retry #8120
@nox nox added S-awaiting-merge and removed S-tests-failed labels Feb 27, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Feb 27, 2016

⚡ Previous build results for android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css are reusable. Rebuilding only mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 27, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit b60d668 into servo:master Feb 27, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@jdm jdm mentioned this pull request Mar 8, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@jdm @highfive @bors-servo @KiChjang @Ms2ger @nox @jxs
You can’t perform that action at this time.