Implement value for DOMTokenList

[Tangresh]

Fixes #9725

[highfive]

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

[Ms2ger]

You'll need to add spec links for those new methods to make ./mach test-tidy happy.

I'm also somewhat concerned that there's no more passing tests.

r? @nox

[Tangresh]

I think there are 4 more tests that pass with this change, should there be more?

[Ms2ger]

Yeah, but the interfaces test only checks that the attribute is implemented, not if it works correctly. I'll see if I can find anything better.

[nox]

The new passing tests check that PutForwards work correctly, but none of them check the actual value of list.value. Trying the PR to see if there are more of them, but unfortunately I don't think there are any.

@bors-servo try

[bors-servo]

⌛ Trying commit 50b1017 with merge c31cb07...

[bors-servo]

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt

[nox]

Could you add a test in tests/wpt/web-platform-tests/dom/nodes/Element-classlist.html that actually use the value attribute?

[Tangresh]

Is the Element-classlist test the right place for such a test? I found a test for DOMTokenList-stringifier, would an equivalent test for value be more appropriate?

[nox]

@Tangresh Now that you mention it, it should just probably go in a new test.

./mach create-wpt tests/wpt/web-platform-tests/dom/lists/DOMTokenList-value.html

[nox]

r=me once you squash the commits.

-S-awaiting-review -C-needs-test -S-needs-tests +S-needs-squash

---

Reviewed 5 of 5 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from the review on Reviewable.io

[nox]

@bors-servo r+

[bors-servo]

📌 Commit b29b2d6 has been approved by nox

[bors-servo]

⌛ Testing commit b29b2d6 with merge 0062870...

[bors-servo]

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt