Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement removeAttributeNode #9774

Merged
merged 1 commit into from Feb 27, 2016
Merged

Conversation

@nox
Copy link
Member

nox commented Feb 26, 2016

Supersedes #8727

Review on Reviewable

This commit implement removeAttributeNode, as described here:
https://dom.spec.whatwg.org/#dom-element-removeattributenode

See also #8724 and #8068.
@nox
Copy link
Member Author

nox commented Feb 26, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Feb 26, 2016

📌 Commit d28c9a1 has been approved by nox

@nox nox assigned nox and unassigned SimonSapin Feb 26, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Feb 27, 2016

Testing commit d28c9a1 with merge e567c8f...

bors-servo added a commit that referenced this pull request Feb 27, 2016
Implement removeAttributeNode

Supersedes #8727

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9774)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 27, 2016

💔 Test failed - linux-rel

@wafflespeanut
Copy link
Member

wafflespeanut commented Feb 27, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Feb 27, 2016

Testing commit d28c9a1 with merge 6c65e15...

bors-servo added a commit that referenced this pull request Feb 27, 2016
Implement removeAttributeNode

Supersedes #8727

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9774)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 27, 2016

@bors-servo bors-servo merged commit d28c9a1 into servo:master Feb 27, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@nox nox deleted the nox:remove-attribute-node branch Feb 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.