Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dispatch_event according to the spec (fixes #9178) #9787

Merged
merged 4 commits into from Feb 29, 2016
Merged

Refactor dispatch_event according to the spec (fixes #9178) #9787

merged 4 commits into from Feb 29, 2016

Conversation

@nox
Copy link
Member

nox commented Feb 28, 2016

Two new functions invoke and invoke_inner are introduced and some invariants documented.

Review on Reviewable
@highfive
Copy link

highfive commented Feb 28, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@nox
Copy link
Member Author

nox commented Feb 28, 2016

r? @Ms2ger
@highfive highfive assigned Ms2ger and unassigned nox Feb 28, 2016
@nox nox mentioned this pull request Feb 28, 2016
Closed
@nox
Copy link
Member Author

nox commented Feb 28, 2016

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Feb 28, 2016

⌛ Trying commit 8c4f01f with merge 83a5bb3...
bors-servo added a commit that referenced this pull request Feb 28, 2016
@bors-servo
Auto merge of #9787 - nox:event-invoke, r=<try>
83a5bb3 
Refactor dispatch_event according to the spec (fixes #9178)

Two new functions invoke and invoke_inner are introduced and some invariants documented.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9787)
<!-- Reviewable:end -->
@nox nox force-pushed the nox:event-invoke branch from 8c4f01f to 4ebed43 Feb 28, 2016
@nox
Copy link
Member Author

nox commented Feb 28, 2016

@bors-servo retry

It seems like the spec is missing the step about checking the "stop immediate propagation" after each call of handleEvent in "invoke inner".
@nox nox force-pushed the nox:event-invoke branch from 4ebed43 to 05c5926 Feb 28, 2016
@nox
Copy link
Member Author

nox commented Feb 28, 2016

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Feb 28, 2016

⌛ Trying commit 05c5926 with merge 73ff425...
bors-servo added a commit that referenced this pull request Feb 28, 2016
@bors-servo
Auto merge of #9787 - nox:event-invoke, r=<try>
73ff425 
Refactor dispatch_event according to the spec (fixes #9178)

Two new functions invoke and invoke_inner are introduced and some invariants documented.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9787)
<!-- Reviewable:end -->
@nox nox force-pushed the nox:event-invoke branch 2 times, most recently from aaa8ab1 to 4fe2fa4 Feb 28, 2016
nox added 4 commits Feb 29, 2016
@nox @Ms2ger
Merge EventTarget::{get_listeners, get_listeners_for}
590316a
@nox @Ms2ger
Return a Vec from EventTarget::get_listeners_for
fc2cf31
@nox @Ms2ger
Rename various bindings in event dispatching
4d2587d
@nox @Ms2ger
Refactor dispatch_event according to the spec (fixes #9178)
Loading status checks…
587963c 
Two new functions invoke and inner_invoke are introduced and some
invariants documented.
@nox nox force-pushed the nox:event-invoke branch from 4fe2fa4 to 587963c Feb 29, 2016
@Ms2ger
Copy link
Contributor

Ms2ger commented Feb 29, 2016

Thanks!

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 29, 2016

📌 Commit 587963c has been approved by Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Feb 29, 2016

⌛ Testing commit 587963c with merge 67d201e...
bors-servo added a commit that referenced this pull request Feb 29, 2016
@bors-servo
Auto merge of #9787 - nox:event-invoke, r=Ms2ger
67d201e 
Refactor dispatch_event according to the spec (fixes #9178)

Two new functions invoke and invoke_inner are introduced and some invariants documented.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9787)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 29, 2016

💔 Test failed - mac-rel-wpt
@nox
Copy link
Member Author

nox commented Feb 29, 2016

@bors-servo retry #9148 #9803
@bors-servo
Copy link
Contributor

bors-servo commented Feb 29, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@nox nox added S-awaiting-merge and removed S-tests-failed labels Feb 29, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Feb 29, 2016

💔 Test failed - linux-rel
@nox
Copy link
Member Author

nox commented Feb 29, 2016

@bors-servo retry #9148 #9803
@bors-servo
Copy link
Contributor

bors-servo commented Feb 29, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
nox added a commit to nox/servo that referenced this pull request Feb 29, 2016
@nox
Vindictively disable all intermittent tests that failed servo#9787
27e098f
nox added a commit to nox/servo that referenced this pull request Feb 29, 2016
@nox
Vindictively disable all intermittent tests that failed servo#9787
29d97b6 
This disables the tests mentioned in servo#8120, servo#9014, servo#9092, servo#9148, servo#9205 and servo#9803.
@bors-servo
Copy link
Contributor

bors-servo commented Feb 29, 2016

💔 Test failed - linux-rel
bors-servo added a commit that referenced this pull request Feb 29, 2016
@bors-servo
Auto merge of #9804 - nox:vengeful-disabling, r=KiChjang
591bc8d 
Vindictively disable all intermittent tests that failed #9787

This disables the tests mentioned in #8120, #9014, #9092, #9148, #9205 and #9803.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9804)
<!-- Reviewable:end -->
@nox
Copy link
Member Author

nox commented Feb 29, 2016

@bors-servo retry #8120 #9777
nox added a commit to nox/servo that referenced this pull request Feb 29, 2016
@nox
Vindictively disable all intermittent tests that failed servo#9787
7aa2b6e 
This disables the tests mentioned in servo#8120, servo#9014, servo#9092, servo#9148, servo#9205 and servo#9803.
@nox
Copy link
Member Author

nox commented Feb 29, 2016

@bors-servo retry #8120 #9777
@bors-servo
Copy link
Contributor

bors-servo commented Feb 29, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
nox added a commit to nox/servo that referenced this pull request Feb 29, 2016
@nox
Vindictively disable all intermittent tests that failed servo#9787
863a5c5 
This disables the tests mentioned in servo#8120, servo#9014, servo#9092, servo#9148, servo#9205 and servo#9803.
@nox
Copy link
Member Author

nox commented Feb 29, 2016

Yet again the same intermittent failures.

@bors-servo retry
bors-servo added a commit that referenced this pull request Feb 29, 2016
@bors-servo
Auto merge of #9804 - nox:vengeful-disabling, r=KiChjang
8c7f42f 
Vindictively disable all intermittent tests that failed #9787

This disables the tests mentioned in #8120, #9014, #9092, #9148, #9205 and #9803.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9804)
<!-- Reviewable:end -->
@nox nox added S-awaiting-merge and removed S-tests-failed labels Feb 29, 2016
nox added a commit to nox/servo that referenced this pull request Feb 29, 2016
@nox
Vindictively disable all intermittent tests that failed servo#9787
ea1c169 
This disables the tests mentioned in servo#8120, servo#9014, servo#9033, servo#9092, servo#9148, servo#9205, servo#9772 and servo#9803.
@nox
Copy link
Member Author

nox commented Feb 29, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 29, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 29, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
bors-servo added a commit that referenced this pull request Feb 29, 2016
@bors-servo
Auto merge of #9804 - nox:vengeful-disabling, r=KiChjang
Loading status checks…
2ba1709 
Vindictively disable all intermittent tests that failed #9787

This disables the tests mentioned in #8120, #9014, #9033, #9092, #9148, #9205, #9772 and #9803.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9804)
<!-- Reviewable:end -->
@bors-servo bors-servo merged commit 587963c into servo:master Feb 29, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@nox nox deleted the nox:event-invoke branch Feb 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ms2ger Ms2ger

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@nox @highfive @bors-servo @Ms2ger
You can’t perform that action at this time.