Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script: Fix remaining bugs from Range.deleteContents #9795

Merged
merged 1 commit into from Feb 28, 2016
Merged

script: Fix remaining bugs from Range.deleteContents #9795

merged 1 commit into from Feb 28, 2016

Conversation

@emilio
Copy link
Member

emilio commented Feb 28, 2016

This makes all the Range.deleteContents tests pass.

I changed some try!()s for unwraps() because those calls are actually infallible.

r? @nox

Review on Reviewable
@nox
Copy link
Member

nox commented Feb 28, 2016

I was going to say something about making a new iterator, but then I realised it is also used in nodeiterator.rs.

@bors-servo r+

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io
@bors-servo
Copy link
Contributor

bors-servo commented Feb 28, 2016

📌 Commit b11e5a5 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Feb 28, 2016

⌛ Testing commit b11e5a5 with merge 06c4f67...
bors-servo added a commit that referenced this pull request Feb 28, 2016
@bors-servo
Auto merge of #9795 - ecoal95:other-range-bugs, r=nox
06c4f67 
script: Fix remaining bugs from Range.deleteContents

This makes all the `Range.deleteContents` tests pass.

I changed some `try!()`s for `unwraps()` because those calls are actually infallible.

r? @nox

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9795)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 28, 2016

💔 Test failed - mac-rel-wpt
@emilio
script: Fix remaining bugs from Range.deleteContents
Loading status checks…
3e36739
@emilio emilio force-pushed the emilio:other-range-bugs branch from b11e5a5 to 3e36739 Feb 28, 2016
@nox
Copy link
Member

nox commented Feb 28, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 28, 2016

📌 Commit 3e36739 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Feb 28, 2016

⌛ Testing commit 3e36739 with merge 492e324...
bors-servo added a commit that referenced this pull request Feb 28, 2016
@bors-servo
Auto merge of #9795 - ecoal95:other-range-bugs, r=nox
Loading status checks…
492e324 
script: Fix remaining bugs from Range.deleteContents

This makes all the `Range.deleteContents` tests pass.

I changed some `try!()`s for `unwraps()` because those calls are actually infallible.

r? @nox

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9795)
<!-- Reviewable:end -->
@nox nox mentioned this pull request Feb 28, 2016
Merged
@bors-servo
Copy link
Contributor

bors-servo commented Feb 28, 2016

💔 Test failed - linux-rel
@nox
Copy link
Member

nox commented Feb 28, 2016

@bors-servo retry #9148
@nox nox added S-awaiting-merge and removed S-tests-failed labels Feb 28, 2016
@emilio
Copy link
Member Author

emilio commented Feb 28, 2016

@bors-servo: r=nox
@bors-servo
Copy link
Contributor

bors-servo commented Feb 28, 2016

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #9792
@bors-servo
Copy link
Contributor

bors-servo commented Feb 28, 2016

📌 Commit 3e36739 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Feb 28, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 28, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member

KiChjang commented Feb 28, 2016

@bors-servo retry
@nox nox added S-awaiting-merge and removed S-tests-failed labels Feb 28, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Feb 28, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 28, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 3e36739 into servo:master Feb 28, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@mbrubeck mbrubeck mentioned this pull request May 25, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@emilio @nox @bors-servo @KiChjang @highfive
You can’t perform that action at this time.