forcetouch events #9811

paulrouget · 2016-02-29T22:38:43Z

https://developer.apple.com/library/mac/documentation/AppleApplications/Conceptual/SafariJSProgTopics/RespondingtoForceTouchEventsfromJavaScript.html

Not sure how we want to land that yet. Maybe reproduce the webkit events (as in this PR), or as touch/mousemouse events.

highfive · 2016-02-29T22:38:47Z

Warning

These commits modify script code, but no tests are modified. Please consider adding a test!

paulrouget · 2016-02-29T22:42:03Z

/cc @mbrubeck

Ms2ger · 2016-03-01T08:18:30Z

No spec at all? Seems like a definite no.

metajack · 2016-03-01T17:17:20Z

Matthew thought this might be handled in part by touch events 2, but that appears not to be the case. We're still kind of digging around to see where it belongs.

I would like to get it in servo since it is really nice and Safari already has it. It makes for amazing demos.

paulrouget · 2016-03-03T22:20:03Z

I'll add a pref.

paulrouget · 2016-03-18T08:27:29Z

The events only fire if the pref dom.forcetouch.enabled is set.
Not sure how I should test that.

Can someone look at this and tell what needs to be done to land that?

paulrouget · 2016-03-21T06:57:34Z

We probably want this too: #10081

mbrubeck · 2016-03-21T19:04:04Z

The code looks good to me, with some minor comments (below).

Before I r+ this, any objections to landing this non-standard feature behind a pref and prefix? Do we need to block on #10081? Do we need a way to make "chrome-only" features?

-S-awaiting-review +S-needs-code-changes +S-needs-decision

Reviewed 1 of 10 files at r1, 10 of 10 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

components/script/dom/document.rs, line 218 [r2] (raw file):
Since we expect stage to be 0, 1, or 2, it would be nice to use an enum instead of an i64, though maybe that should go in glutin.

components/script/dom/document.rs, line 798 [r2] (raw file):
From the Safari docs, mouseforcechanged should be dispatched only after mousedown and before mouseup. (I think this means it should be dispatched only if stage > 1).

Comments from the review on Reviewable.io

paulrouget · 2016-03-21T19:17:43Z

Do we need a way to make "chrome-only" features?

Just FYI, so far, "chrome" features are: Mozbrowser API and cross-origin xhr (WIP #10068). Both are only available if 1) the mozbrowser pref is turned on 2) the API is used in the root pipeline.

paulrouget · 2016-03-22T12:37:29Z

Addressed comments.

I remove webkitmouseforcewillbegin for now. It's only useful if the preventDefault() works, which I don't think it is yet. I will implement it in a follow-up bug (and make sure browserhtml actually follow this behavior).

mbrubeck · 2016-03-22T21:09:04Z

@bors-servo r+

Reviewed 10 of 10 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

bors-servo · 2016-03-22T21:09:04Z

📌 Commit 35e3ae2 has been approved by mbrubeck

paulrouget · 2016-04-01T07:59:03Z

(rebased and added pref to prefs.json)


        forcetouch events support

This enables Apple forcetouch DOM events. It requires the preference dom.forcetouch.enabled. The DOM events are described here: - https://developer.apple.com/library/mac/documentation/AppleApplications/Conceptual/SafariJSProgTopics/RespondingtoForceTouchEventsfromJavaScript.html The Cocoa mechanism is documented here: - https://developer.apple.com/library/mac/documentation/Cocoa/Reference/ApplicationKit/Classes/NSEvent_Class/#//apple_ref/doc/uid/20000016-SW274


        Ignore ForceTouchEvent.webidl

paulrouget · 2016-04-05T10:45:12Z

I'm not sure when #10081 will land. So I've updated my PR and added ForceTouchEvent to interfaces.html. This test will fail with #10081.

paulrouget · 2016-04-05T11:59:56Z

@bors-servo retry

infra

jdm · 2016-04-05T12:31:25Z

@bors-servo: r=mbrubeck

bors-servo · 2016-04-05T12:31:26Z

📌 Commit 0d52927 has been approved by mbrubeck

bors-servo · 2016-04-05T13:15:31Z

⌛ Testing commit 0d52927 with merge c0d03e2...


        Auto merge of #9811 - paulrouget:forceTouch, r=mbrubeck

forcetouch events https://developer.apple.com/library/mac/documentation/AppleApplications/Conceptual/SafariJSProgTopics/RespondingtoForceTouchEventsfromJavaScript.html Not sure how we want to land that yet. Maybe reproduce the webkit events (as in this PR), or as touch/mousemouse events.  [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9811)

bors-servo · 2016-04-05T13:55:20Z

💔 Test failed - mac-rel-wpt

larsbergstrom · 2016-04-05T14:30:31Z

Tests with unexpected results:
  ▶ TIMEOUT [expected OK] /cssom-view/scrollingElement.html
  │ 
  │ ERROR:js::rust: Error at http://web-platform.test:8000/cssom-view/scrollingElement.html:14:4: URL.createObjectURL is not a function
  │ 
  │ ERROR:js::rust: Error at http://web-platform.test:8000/cssom-view/scrollingElement.html:11:6: URL.createObjectURL is not a function
  └ 

  ▶ Unexpected subtest result in /cssom-view/scrollingElement.html:
  └ NOTRUN [expected FAIL] Tests for scrollingElement

jdm · 2016-04-05T14:37:14Z

@bors-servo: retry

#10398

bors-servo · 2016-04-05T15:37:06Z

⌛ Testing commit 0d52927 with merge 0ff8adb...


        Auto merge of #9811 - paulrouget:forceTouch, r=mbrubeck

forcetouch events https://developer.apple.com/library/mac/documentation/AppleApplications/Conceptual/SafariJSProgTopics/RespondingtoForceTouchEventsfromJavaScript.html Not sure how we want to land that yet. Maybe reproduce the webkit events (as in this PR), or as touch/mousemouse events.  [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9811)

bors-servo · 2016-04-05T16:33:22Z

☀️ Test successful - android, arm32, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, status-appveyor

highfive assigned glennw Feb 29, 2016

highfive added the S-awaiting-review label Feb 29, 2016

paulrouget added the A-browserhtml/P2 label Feb 29, 2016

paulrouget added the C-assigned label Mar 14, 2016

paulrouget force-pushed the paulrouget:forceTouch branch 4 times, most recently from a98e42f to 656f7a8 Mar 16, 2016

paulrouget changed the title ~~[WIP] forcetouch events~~ forcetouch events Mar 18, 2016

glennw assigned mbrubeck and unassigned glennw Mar 20, 2016

mbrubeck added S-needs-code-changes S-needs-decision and removed S-awaiting-review labels Mar 21, 2016

paulrouget force-pushed the paulrouget:forceTouch branch from 656f7a8 to 35e3ae2 Mar 22, 2016

highfive added S-awaiting-review and removed S-needs-code-changes labels Mar 22, 2016

highfive removed the S-awaiting-review label Mar 22, 2016

paulrouget force-pushed the paulrouget:forceTouch branch from 9c6e88e to ca0a3d7 Apr 1, 2016

highfive added S-awaiting-review and removed S-tests-failed labels Apr 1, 2016

paulrouget added 2 commits Mar 18, 2016

Ignore ForceTouchEvent.webidl

Loading status checks…

0d52927

paulrouget force-pushed the paulrouget:forceTouch branch from ca0a3d7 to 0d52927 Apr 5, 2016

highfive added S-awaiting-merge and removed S-awaiting-review S-needs-rebase labels Apr 5, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Apr 5, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels Apr 5, 2016

bors-servo merged commit 0d52927 into servo:master Apr 5, 2016
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Apr 5, 2016

This was referenced Apr 5, 2016

Refactors some entities from script_thread into script_runtime #10342

Merged

Implement origin concept and browsing contextless documents. #8658

Merged

servo / servo

forcetouch events #9811

forcetouch events #9811

paulrouget commented Feb 29, 2016

highfive commented Feb 29, 2016

paulrouget commented Feb 29, 2016

Ms2ger commented Mar 1, 2016

metajack commented Mar 1, 2016

paulrouget commented Mar 3, 2016

paulrouget commented Mar 18, 2016

paulrouget commented Mar 21, 2016

mbrubeck commented Mar 21, 2016

paulrouget commented Mar 21, 2016

paulrouget commented Mar 22, 2016

mbrubeck commented Mar 22, 2016

bors-servo commented Mar 22, 2016

paulrouget commented Apr 1, 2016

paulrouget commented Apr 5, 2016

paulrouget commented Apr 5, 2016

jdm commented Apr 5, 2016

bors-servo commented Apr 5, 2016

bors-servo commented Apr 5, 2016

bors-servo commented Apr 5, 2016

larsbergstrom commented Apr 5, 2016

jdm commented Apr 5, 2016

bors-servo commented Apr 5, 2016

bors-servo commented Apr 5, 2016

servo / servo

Join GitHub today

forcetouch events #9811

forcetouch events #9811

Conversation

paulrouget commented Feb 29, 2016

highfive commented Feb 29, 2016

paulrouget commented Feb 29, 2016

Ms2ger commented Mar 1, 2016

metajack commented Mar 1, 2016

paulrouget commented Mar 3, 2016

paulrouget commented Mar 18, 2016

paulrouget commented Mar 21, 2016

mbrubeck commented Mar 21, 2016

paulrouget commented Mar 21, 2016

paulrouget commented Mar 22, 2016

mbrubeck commented Mar 22, 2016

bors-servo commented Mar 22, 2016

paulrouget commented Apr 1, 2016

paulrouget commented Apr 5, 2016

paulrouget commented Apr 5, 2016

jdm commented Apr 5, 2016

bors-servo commented Apr 5, 2016

bors-servo commented Apr 5, 2016

bors-servo commented Apr 5, 2016

larsbergstrom commented Apr 5, 2016

jdm commented Apr 5, 2016

bors-servo commented Apr 5, 2016

bors-servo commented Apr 5, 2016