Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating the CanvasRenderingContext2D to match the spec #9823

Merged
merged 1 commit into from Mar 1, 2016
Merged

updating the CanvasRenderingContext2D to match the spec #9823

merged 1 commit into from Mar 1, 2016
+66 −4

Conversation

@gmalecha
Copy link
Contributor

gmalecha commented Mar 1, 2016

Review on Reviewable
@gmalecha
updating the CanvasRenderingContext2D to match the spec
Loading status checks…
2c66361 
- fixes #9443
@highfive
Copy link

highfive commented Mar 1, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.
@highfive
Copy link

highfive commented Mar 1, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Mar 1, 2016

@bors-servo: r+
Thank you!
@bors-servo
Copy link
Contributor

bors-servo commented Mar 1, 2016

📌 Commit 2c66361 has been approved by jdm
@jdm jdm assigned jdm and unassigned wafflespeanut Mar 1, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Mar 1, 2016

⌛ Testing commit 2c66361 with merge 13da10d...
bors-servo added a commit that referenced this pull request Mar 1, 2016
@bors-servo
Auto merge of #9823 - gmalecha:canvas-rendering-context-2d-update-idl…
13da10d 
…, r=jdm

updating the CanvasRenderingContext2D to match the spec

- fixes #9443

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9823)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 1, 2016

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Mar 1, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Mar 1, 2016

⌛ Testing commit 2c66361 with merge f895f87...
bors-servo added a commit that referenced this pull request Mar 1, 2016
@bors-servo
Auto merge of #9823 - gmalecha:canvas-rendering-context-2d-update-idl…
Loading status checks…
f895f87 
…, r=jdm

updating the CanvasRenderingContext2D to match the spec

- fixes #9443

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9823)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 1, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 2c66361 into servo:master Mar 1, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Update the canvas webidl to match the spec
5 participants
@gmalecha @highfive @jdm @bors-servo @wafflespeanut
You can’t perform that action at this time.