Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Implementation of document.getElementById() #983

Merged
merged 3 commits into from Oct 14, 2013

Conversation

@saneyuki
Copy link
Member

commented Sep 29, 2013

This has not implemented these features yet:

  • Update hashmap which is used for getElementById() when updating element attributes.
  • Keep node order in tree.

However, this has the quality of that we can use this method for testcases.

@saneyuki

This comment has been minimized.

Copy link
Member Author

commented Sep 29, 2013

@jdm r?

@jdm

This comment has been minimized.

Copy link
Member

commented Sep 29, 2013

This is a good start - let's focus on moving to traverse_preorder, not using @mut, and passing an abstract_self argument when we need it.

@saneyuki

This comment has been minimized.

Copy link
Member Author

commented Oct 4, 2013

I rebased patches.

@jdm how about theses?

@jdm

This comment has been minimized.

Copy link
Member

commented Oct 9, 2013

This is looking pretty good. If you could fix up my comments and rebase over the deletion of remove_from_doc, this should be ready to land.

@saneyuki

This comment has been minimized.

Copy link
Member Author

commented Oct 14, 2013

Rebased!

Change:

  • Reflect reviews.
  • Cancel to split the signaling part from Node.add_to_doc(). Node.remove_from_doc() is removed on #1027. Therefore the splitting is needless at now.
@jdm

This comment has been minimized.

Copy link

commented on db3b5c3 Oct 14, 2013

r+

@jdm

This comment has been minimized.

Copy link
Member

commented Oct 14, 2013

Thanks!

@saneyuki

This comment has been minimized.

Copy link
Member Author

commented Oct 14, 2013

You're most welcome!!

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented on db3b5c3 Oct 14, 2013

saw approval from jdm
at saneyuki@db3b5c3

This comment has been minimized.

Copy link
Contributor

replied Oct 14, 2013

merging saneyuki/servo/getid = db3b5c3 into auto

This comment has been minimized.

Copy link
Contributor

replied Oct 14, 2013

saneyuki/servo/getid = db3b5c3 merged ok, testing candidate = 90baad3

This comment has been minimized.

Copy link
Contributor

replied Oct 14, 2013

fast-forwarding master to auto = 90baad3

bors-servo pushed a commit that referenced this pull request Oct 14, 2013
This has not implemented these features yet:
* Update hashmap which is used for `getElementById()` when updating element attributes.
* Keep node order in tree.

However, this has the quality of that we can use this method for testcases.
@bors-servo bors-servo merged commit db3b5c3 into servo:master Oct 14, 2013
1 check passed
1 check passed
default all tests passed
ChrisParis pushed a commit to ChrisParis/servo that referenced this pull request Sep 7, 2014
assert 4th argument is a non-specific number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.