Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unexpected overflow with overflow: hidden set. #9841

Merged
merged 1 commit into from Mar 2, 2016
Merged

Fix unexpected overflow with overflow: hidden set. #9841

merged 1 commit into from Mar 2, 2016

Conversation

@glennw
Copy link
Member

glennw commented Mar 2, 2016

Fixes #9719.

Review on Reviewable
@gw3583
Fix unexpected overflow with overflow: hidden set.
Loading status checks…
ff831bb 
Fixes #9719.
@highfive
Copy link

highfive commented Mar 2, 2016

warning Warning warning

  • These commits modify layout code, but no tests are modified. Please consider adding a test!
@pcwalton
Copy link
Contributor

pcwalton commented Mar 2, 2016

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 2, 2016

📌 Commit ff831bb has been approved by pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented Mar 2, 2016

⌛ Testing commit ff831bb with merge 3ff5082...
bors-servo added a commit that referenced this pull request Mar 2, 2016
@bors-servo
Auto merge of #9841 - glennw:extra-overflow, r=pcwalton
Loading status checks…
3ff5082 
Fix unexpected overflow with overflow: hidden set.

Fixes #9719.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9841)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 2, 2016

💔 Test failed - linux-rel
@emilio
Copy link
Member

emilio commented Mar 2, 2016 

PASS [expected FAIL] /css21_dev/html4/quotes-036.htm
@frewsxcv
Copy link
Member

frewsxcv commented Mar 2, 2016

@bors-servo retry #7846
@bors-servo
Copy link
Contributor

bors-servo commented Mar 2, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 2, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo mentioned this pull request Mar 2, 2016
Closed
@bors-servo bors-servo merged commit ff831bb into servo:master Mar 2, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@jdm
Copy link
Member

jdm commented Mar 3, 2016

Was it impossible to write a reftests?
@glennw
Copy link
Member Author

glennw commented Mar 3, 2016

@jdm Yep, it relies on mouse scroll.
@glennw glennw deleted the glennw:extra-overflow branch Mar 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
@glennw @highfive @pcwalton @bors-servo @emilio @frewsxcv @jdm @gw3583
You can’t perform that action at this time.