Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix animation smoothness when using requestAnimationFrame. #9858

Merged
merged 1 commit into from Mar 4, 2016

Commits on Mar 3, 2016

  1. Fix animation smoothness when using requestAnimationFrame.

    Previously, the flow for ticking animations was:
    
    Compositor -> Constellation -> Layout -> Script
    
    However, this means that the compositor <-> layout messages can thrash, meaning layout thread is very rarely idle.
    
    This means that the script thread (which joins on the layout thread during reflow) was unable to execute and run rAF callbacks.
    
    With this change, the flow is now:
    
    Compositor -> Constellation -> Script (when rAF is active).
    Compositor -> Constellation -> Layout (when transitions / animations are active and no rAF is present).
    
    This makes rAF based animation *much* smoother.
    gw3583 committed Mar 3, 2016
You can’t perform that action at this time.