Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unrevert the fix for hit testing through shadows #9866

Merged
merged 1 commit into from Mar 4, 2016
Merged

Unrevert the fix for hit testing through shadows #9866

merged 1 commit into from Mar 4, 2016

Conversation

@metajack
Copy link
Contributor

metajack commented Mar 4, 2016

This was originally #9428 but got accidentally reverted during rebase in

Fixes #9865.

Review on Reviewable
@metajack
Unrevert the fix for hit testing through shadows
Loading status checks…
f7aa6a3 
This was originally #9428 but got accidentally reverted during rebase in

Fixes #9865.
@highfive
Copy link

highfive commented Mar 4, 2016

warning Warning warning

  • These commits modify gfx code, but no tests are modified. Please consider adding a test!
@metajack
Copy link
Contributor Author

metajack commented Mar 4, 2016

r? @pcwalton or @mrobinson
@highfive highfive assigned pcwalton and unassigned Ms2ger Mar 4, 2016
@pcwalton
Copy link
Contributor

pcwalton commented Mar 4, 2016

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 4, 2016

📌 Commit f7aa6a3 has been approved by pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented Mar 4, 2016

⌛ Testing commit f7aa6a3 with merge 12466b8...
bors-servo added a commit that referenced this pull request Mar 4, 2016
@bors-servo
Auto merge of #9866 - metajack:refix-shadow-hit-test, r=pcwalton
Loading status checks…
12466b8 
Unrevert the fix for hit testing through shadows

This was originally #9428 but got accidentally reverted during rebase in

Fixes #9865.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9866)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 4, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit f7aa6a3 into servo:master Mar 4, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@metajack metajack deleted the metajack:refix-shadow-hit-test branch Mar 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pcwalton pcwalton

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@metajack @highfive @pcwalton @bors-servo @Ms2ger
You can’t perform that action at this time.