Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unrevert the fix for hit testing through shadows #9866

Merged
merged 1 commit into from
Mar 4, 2016
Merged

Unrevert the fix for hit testing through shadows #9866

merged 1 commit into from
Mar 4, 2016

Conversation

metajack
Copy link
Contributor

@metajack metajack commented Mar 4, 2016

This was originally #9428 but got accidentally reverted during rebase in

Fixes #9865.

Review on Reviewable

@metajack
Unrevert the fix for hit testing through shadows
f7aa6a3 
This was originally servo#9428 but got accidentally reverted during rebase in

Fixes servo#9865.
@highfive
Copy link

highfive commented Mar 4, 2016

warning Warning warning

  • These commits modify gfx code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 4, 2016
@metajack
Copy link
Contributor Author

metajack commented Mar 4, 2016

r? @pcwalton or @mrobinson

@highfive highfive assigned pcwalton and unassigned Ms2ger Mar 4, 2016
@pcwalton
Copy link
Contributor

pcwalton commented Mar 4, 2016

@bors-servo: r+

@bors-servo
Copy link
Contributor

📌 Commit f7aa6a3 has been approved by pcwalton

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 4, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit f7aa6a3 with merge 12466b8...

bors-servo pushed a commit that referenced this pull request Mar 4, 2016
Auto merge of #9866 - metajack:refix-shadow-hit-test, r=pcwalton
12466b8 
Unrevert the fix for hit testing through shadows

This was originally #9428 but got accidentally reverted during rebase in

Fixes #9865.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9866)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt

@bors-servo bors-servo merged commit f7aa6a3 into servo:master Mar 4, 2016
@metajack metajack deleted the refix-shadow-hit-test branch March 4, 2016 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pcwalton pcwalton

Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@metajack @highfive @pcwalton @bors-servo @Ms2ger