Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use `cursor: text` in text input areas #9872

Merged
merged 1 commit into from Mar 4, 2016
Merged

Use `cursor: text` in text input areas #9872

merged 1 commit into from Mar 4, 2016

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Mar 4, 2016

… not just over text.

Fix #9486.

Review on Reviewable

@@ -30,3 +30,6 @@ td[align="right"] { text-align: right; }

center { text-align: -servo-center; }

input:not([type="radio"]):not([type="checkbox"]):not([type="reset"]):not([type="button"]):not([type="submit"]),

This comment has been minimized.

@nox

nox Mar 4, 2016

Member

Shouldn't it be [type=radio i]? At the very least the quotes are not needed.

… not just over text.

Fix #9486.
@SimonSapin SimonSapin force-pushed the cursor-text branch from e6a87da to 428dab1 Mar 4, 2016
@SimonSapin
Copy link
Member Author

SimonSapin commented Mar 4, 2016

@bors-servo r=nox

@bors-servo
Copy link
Contributor

bors-servo commented Mar 4, 2016

📌 Commit 428dab1 has been approved by nox

@bors-servo
Copy link
Contributor

bors-servo commented Mar 4, 2016

Testing commit 428dab1 with merge b4cae84...

bors-servo added a commit that referenced this pull request Mar 4, 2016
Use `cursor: text` in text input areas

… not just over text.

Fix #9486.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9872)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 4, 2016

@bors-servo bors-servo merged commit 428dab1 into master Mar 4, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Mar 4, 2016
@SimonSapin SimonSapin deleted the cursor-text branch Mar 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.