Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake Cargo share more things between servo and ports #9886
Merged
Conversation
highfive
commented
Mar 5, 2016
|
Heads up! This PR modifies the following files:
|
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Mar 5, 2016
Consistently select the unstable feature in string_cache and selectors This should enable Cargo to reuse more build artifacts between servo and geckolib.
nox
changed the title
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Mar 5, 2016
Make Cargo share more things between servo and geckolib This should enable Cargo to reuse more build artifacts between servo and geckolib. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9886) <!-- Reviewable:end -->
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Mar 5, 2016
Make Cargo share more things between servo and geckolib This should enable Cargo to reuse more build artifacts between servo and geckolib. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9886) <!-- Reviewable:end -->
|
Last commit probably requires @bholley's seal of approval. |
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Mar 5, 2016
Make Cargo share more things between servo and geckolib This should enable Cargo to reuse more build artifacts between servo and geckolib. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9886) <!-- Reviewable:end -->
|
|
|
Never mind, encoding was already depended upon by cssparser so it's already in geckolib. |
nox
changed the title
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Mar 5, 2016
(DO NOT MERGE) Make Cargo share more things between servo and geckolib This should enable Cargo to reuse more build artifacts between servo and geckolib. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9886) <!-- Reviewable:end -->
|
|
|
Result of running |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 7, 2016
Make Cargo share more things between servo and geckolib This should enable Cargo to reuse more build artifacts between servo and geckolib. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9886) <!-- Reviewable:end -->
|
|
This should enable Cargo to reuse more build artifacts between servo and geckolib.
Some external dependencies (at least webrender_traits) present only in servo and not in geckolib use it already and this prevents Cargo to reuse build artifacts depending on serde between the two targets.
This allows the reuse of teh build artifacts of url and all the things that depends on it between servo and geckolib.
nox
changed the title
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Mar 8, 2016
Make Cargo share more things between servo and ports This should enable Cargo to reuse more build artifacts between servo and geckolib. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9886) <!-- Reviewable:end -->
|
|
|
@bors-servo r=SimonSapin |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 8, 2016
Make Cargo share more things between servo and ports This should enable Cargo to reuse more build artifacts between servo and geckolib. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9886) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nox commentedMar 5, 2016
This should enable Cargo to reuse more build artifacts between servo and geckolib.