Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate to Rust 2016-03-05 #9888
Merged
Conversation
highfive
commented
Mar 6, 2016
|
|
|
This is surprisingly way simpler than I expected it to be. |
| @@ -29,7 +29,7 @@ pub enum HeaderOrMethod { | |||
| impl HeaderOrMethod { | |||
| fn match_header(&self, header_name: &str) -> bool { | |||
| match *self { | |||
| HeaderOrMethod::HeaderData(ref s) => s.eq_ignore_ascii_case(header_name), | |||
| HeaderOrMethod::HeaderData(ref s) => (&**s).eq_ignore_ascii_case(header_name), | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@Manishearth Just bumped tenacious to 0.1.0 now you published it. r? |
|
Reviewed 8 of 12 files at r1, 5 of 5 files at r2. Comments from the review on Reviewable.io |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 6, 2016
Update to Rust 2016-03-05 Blocked by Manishearth/rust-tenacious#14. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9888) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nox commentedMar 6, 2016
Blocked by Manishearth/rust-tenacious#14.