Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated fs::walk_dir call with walkdir crate #9891

Merged
merged 1 commit into from Mar 7, 2016
Merged

Replace deprecated fs::walk_dir call with walkdir crate #9891

merged 1 commit into from Mar 7, 2016

Conversation

@cengizIO
Copy link
Contributor

cengizIO commented Mar 7, 2016

While working on #8351 I discovered that deprecated fs::walk_dir is used in android support files.

This is my first PR to any Rust project, so any constructive feedback is more than welcome!

Thanks

Review on Reviewable
@cengizIO
Replace deprecated fs::walk_dir call with walkdir crate
Loading status checks…
12100ed
@highfive
Copy link

highfive commented Mar 7, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @ecoal95 (or someone else) soon.
@emilio emilio assigned emilio and unassigned glennw Mar 7, 2016
@emilio
Copy link
Member

emilio commented Mar 7, 2016

It looks great, thanks! And thanks for taking rid of the trailing whitespace there, I guess tidy doesn't scan that file?

Thank you again!

-S-awaiting-review +S-awaiting-merge

@bors-servo: r+

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io
@bors-servo
Copy link
Contributor

bors-servo commented Mar 7, 2016

📌 Commit 12100ed has been approved by ecoal95
@bors-servo
Copy link
Contributor

bors-servo commented Mar 7, 2016

⌛ Testing commit 12100ed with merge dedae5e...
bors-servo added a commit that referenced this pull request Mar 7, 2016
@bors-servo
Auto merge of #9891 - cengizIO:master, r=ecoal95
Loading status checks…
dedae5e 
Replace deprecated fs::walk_dir call with walkdir crate

While working on #8351 I discovered that deprecated fs::walk_dir is used in android support files.

This is my first PR to any Rust project, so any constructive feedback is more than welcome!

Thanks

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9891)
<!-- Reviewable:end -->
@emilio emilio mentioned this pull request Mar 7, 2016
Closed
@cengizIO
Copy link
Contributor Author

cengizIO commented Mar 7, 2016

@ecoal95 Hello!

Thank you for warm welcome.

It's a pleasure to contribute.
@bors-servo
Copy link
Contributor

bors-servo commented Mar 7, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, status-appveyor
@bors-servo bors-servo merged commit 12100ed into servo:master Mar 7, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@cengizIO @highfive @emilio @bors-servo @glennw
You can’t perform that action at this time.