Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageCache cleanup. #9892

Merged
merged 5 commits into from Mar 7, 2016
Merged

ImageCache cleanup. #9892

merged 5 commits into from Mar 7, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Mar 7, 2016

Review on Reviewable
Ms2ger added 5 commits Mar 7, 2016
@Ms2ger
Move the ImageCacheThread's closure into a function.
6de127a
@Ms2ger
Use the select! macro in ImageCacheThread.
9c4f226
@Ms2ger
Inline ImageCache::do_run.
9c75ddf
@Ms2ger
Move the receivers out of the ImageCache struct.
1064c3d
@Ms2ger
Bonus fix: Rewrite get_image_or_meta_if_available in an imperative st…
Loading status checks…
d5b559c 
…yle.

I believe this is more readable.
@highfive
Copy link

highfive commented Mar 7, 2016

warning Warning warning

  • These commits modify net code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Mar 7, 2016

@bors-servo: r+
Nice cleanup! Thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Mar 7, 2016

📌 Commit d5b559c has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Mar 7, 2016

⌛ Testing commit d5b559c with merge 1330e7e...
bors-servo added a commit that referenced this pull request Mar 7, 2016
@bors-servo
Auto merge of #9892 - Ms2ger:imagecache, r=jdm
Loading status checks…
1330e7e 
ImageCache cleanup.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9892)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 7, 2016

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Mar 7, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Mar 7, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt, status-appveyor are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 7, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, status-appveyor
@bors-servo bors-servo merged commit d5b559c into servo:master Mar 7, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Mar 7, 2016
Merged
@Ms2ger Ms2ger deleted the Ms2ger:imagecache branch Mar 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@Ms2ger @highfive @jdm @bors-servo
You can’t perform that action at this time.