Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly use "pub extern crate" #9898

Merged
merged 1 commit into from Mar 8, 2016
Merged

Properly use "pub extern crate" #9898

merged 1 commit into from Mar 8, 2016

Conversation

@nox
Copy link
Member

nox commented Mar 7, 2016

Review on Reviewable
@nox
Properly use "pub extern crate"
Loading status checks…
c424d54
@Ms2ger
Copy link
Contributor

Ms2ger commented Mar 7, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 7, 2016

📌 Commit c424d54 has been approved by Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Mar 8, 2016

⌛ Testing commit c424d54 with merge c200abe...
bors-servo added a commit that referenced this pull request Mar 8, 2016
@bors-servo
Auto merge of #9898 - nox:fix-private-in-public, r=Ms2ger
Loading status checks…
c200abe 
Properly use "pub extern crate"

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9898)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 8, 2016

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Mar 8, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Mar 8, 2016

⌛ Testing commit c424d54 with merge 22244cf...
bors-servo added a commit that referenced this pull request Mar 8, 2016
@bors-servo
Auto merge of #9898 - nox:fix-private-in-public, r=Ms2ger
Loading status checks…
22244cf 
Properly use "pub extern crate"

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9898)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 8, 2016

💔 Test failed - linux-rel
@Ms2ger
Copy link
Contributor

Ms2ger commented Mar 8, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Mar 8, 2016

⌛ Testing commit c424d54 with merge 60d97c3...
bors-servo added a commit that referenced this pull request Mar 8, 2016
@bors-servo
Auto merge of #9898 - nox:fix-private-in-public, r=Ms2ger
Loading status checks…
60d97c3 
Properly use "pub extern crate"

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9898)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 8, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, status-appveyor
@bors-servo bors-servo merged commit c424d54 into servo:master Mar 8, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ms2ger Ms2ger

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@nox @Ms2ger @bors-servo @jdm @highfive
You can’t perform that action at this time.