Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate heartbeats and energymon profiler dependencies #9926
Conversation
highfive
commented
Mar 8, 2016
|
@larsbergstrom can you take a look at tests/heartbeats/characterize_android.py? |
|
Reviewed 6 of 9 files at r1. components/script/parser.out, line 0 [r1] (raw file): tests/heartbeats/characterize.py, line 26 [r1] (raw file): Comments from the review on Reviewable.io |
|
Mostly looks fine. It'd be nice to get someone who knows their way round the android build to look at it. Do you know why parser.out changed? |
|
I don't have any idea what that parser thing is. I commented out that profiler category because it doesn't use the profiling interface properly and therefore doesn't behave like the others. It screws up data in log files and the chart generation by the Basically all the heartbeats changes are just better build support, esp. for cross compiling (also now using Alex's The real changes are in the |
|
Review status: 6 of 9 files reviewed at latest revision, 2 unresolved discussions. tests/heartbeats/characterize.py, line 26 [r1] (raw file): Comments from the review on Reviewable.io |
|
Reviewed 1 of 9 files at r1. components/script/parser.out, line [r1] (raw file): Comments from the review on Reviewable.io |
2bf1e66
to
5215573
|
I'm going to regret asking this, but... over in https://github.com/libheartbeats/heartbeats-simple/blob/master/LICENSE the copyright holder is given as "The University of Chicago". Is this correct? |
|
Ah, I didn't even realize I had added a deleted file back in. Maybe something happened pushing/popping my git stash when I pulled to get the latest changes before making my branch. Sorry about that - good catch. I've deleted the file and rebased my commit. |
|
Reviewed 1 of 9 files at r1, 1 of 1 files at r2. Comments from the review on Reviewable.io |
|
We chose the 3-clause BSD license when we released Heartbeats source as part of other work. The |
|
Is UoC the copyright holder? I'm a bit concerned that if they are, we need someone to officially bless the licensing. |
|
I'm a graduate student at UofC and primary developer of the libraries. Per the licensing, nobody at UofC's end has to bless the redistribution, nor is it a copyleft license. If you need blessing from inside Mozilla, I think @larsbergstrom can provide that. |
|
Sorry to harp on about this, but is UoC the copyright holder? If they are, we need to think about the licensing. If not, could you update the LICENSE files? |
5215573
to
2ab12a3
|
I've updated the license files for the |
|
Thanks! |
|
Reviewed 1 of 1 files at r3. Comments from the review on Reviewable.io |
|
@larsbergstrom did tests/heartbeats/characterize_android.py look good to you? @bors-servo try |
|
|
Update heartbeats and energymon profiler dependencies Heartbeats now on crates.io. Updates to energymon interface for energy profiling. Profiling script for Android. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9926) <!-- Reviewable:end -->
|
|
Updates to energymon interface for energy profiling. Profiling script for Android.
3cad3cd
to
f31e884
|
I rebased this yesterday afternoon. Did it become unmergeable again? Or is something else missing? |
|
@bors-servo r=asajeffrey Unlike nearly every other action on GitHub, rebases / pushing extra commits to a branch does not send any update mails. |
|
|
|
I knew that but I thought highfive automatically picked it up. Thanks. |
…ajeffrey Update heartbeats and energymon profiler dependencies Heartbeats now on crates.io. Updates to energymon interface for energy profiling. Profiling script for Android. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9926) <!-- Reviewable:end -->
|
|
|
@bors-servo retry
|
…ajeffrey Update heartbeats and energymon profiler dependencies Heartbeats now on crates.io. Updates to energymon interface for energy profiling. Profiling script for Android. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9926) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
|
|
|
|
|
Yay! Thanks, @connorimes! |
connorimes commentedMar 8, 2016
Heartbeats now on crates.io.
Updates to energymon interface for energy profiling.
Profiling script for Android.