Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute damage even when incremental layout is disabled #9964

Merged
merged 1 commit into from Mar 12, 2016
Merged

Compute damage even when incremental layout is disabled #9964

merged 1 commit into from Mar 12, 2016

Conversation

@mbrubeck
Copy link
Contributor

mbrubeck commented Mar 10, 2016

This fixes traversals that use the damage flags to decide which nodes to process, such as resolve_generated_content, which was broken in non-incremental mode. r? @pcwalton

This change is Review on Reviewable
@highfive
Copy link

highfive commented Mar 10, 2016

warning Warning warning

  • These commits modify layout code, but no tests are modified. Please consider adding a test!
@pcwalton
Copy link
Contributor

pcwalton commented Mar 11, 2016

Can you add a comment so this doesn't regress?
@mbrubeck mbrubeck mentioned this pull request Mar 11, 2016
Closed
@mbrubeck
Compute damage even when incremental layout is disabled
Loading status checks…
ae5cfc3 
This fixes traversals that use the damage flags to decide which nodes to
process, such as `resolve_generated_content`, which was broken in
non-incremental mode.
@mbrubeck mbrubeck force-pushed the mbrubeck:incremental-damage branch from f520b5a to ae5cfc3 Mar 11, 2016
@mbrubeck
Copy link
Contributor Author

mbrubeck commented Mar 11, 2016

Added a comment. r? @pcwalton
@pcwalton
Copy link
Contributor

pcwalton commented Mar 11, 2016

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 11, 2016

📌 Commit ae5cfc3 has been approved by pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented Mar 11, 2016

⌛ Testing commit ae5cfc3 with merge d330ecd...
bors-servo added a commit that referenced this pull request Mar 11, 2016
@bors-servo
Auto merge of #9964 - mbrubeck:incremental-damage, r=pcwalton
Loading status checks…
d330ecd 
Compute damage even when incremental layout is disabled

This fixes traversals that use the damage flags to decide which nodes to process, such as `resolve_generated_content`, which was broken in non-incremental mode. r? @pcwalton

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9964)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 12, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, status-appveyor
@bors-servo bors-servo merged commit ae5cfc3 into servo:master Mar 12, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@mbrubeck mbrubeck deleted the mbrubeck:incremental-damage branch May 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pcwalton pcwalton

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@mbrubeck @highfive @pcwalton @bors-servo
You can’t perform that action at this time.