Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upConvert directly from DOMString to Vec<u8> #9967
Merged
Conversation
highfive
commented
Mar 11, 2016
|
|
|
@bors-servo r+ Thank you! |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 11, 2016
Convert directly from DOMString to Vec<u8> <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9967) <!-- Reviewable:end -->
|
|
components/script/dom/blob.rs
Outdated
| @@ -124,8 +124,7 @@ impl Blob { | |||
| blobPropertyBag: &BlobBinding::BlobPropertyBag) | |||
| -> Fallible<Root<Blob>> { | |||
| // TODO: accept other blobParts types - ArrayBuffer or ArrayBufferView or Blob | |||
| // FIXME(ajeffrey): convert directly from a DOMString to a Vec<u8> | |||
| let bytes: Vec<u8> = String::from(blobParts).into_bytes(); | |||
| let bytes: Vec<u8> = blobParts.into(); | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors-servo: r=Ms2ger |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 11, 2016
Convert directly from DOMString to Vec<u8> <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9967) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
saurvs commentedMar 11, 2016
This change is