After demonstrated competence not only at writing code for a component of Servo, but also at reviewing code within that component, we will consider granting review / merge privileges to new members. If you would like to consider having these permissions, please bring it up with @larsbergstrom and @metajack, and they will verify with an appropriate super-reviewer before granting review / merge privilege.
This verification will involve ensuring that a super-reviewer has ensured the proposed reviewer's reviews are consistent with the expectations of the project.
While review privileges are traditionally project-wide, it is also possible to have specific reviewer privileges for certain repositories. This is controlled using extra_reviewers in the Homu config, as opposed to the main reviewers list.
While review privilege is global to Servo and all its associated projects, it is expected that significant changes in key areas - particularly that are exposed to web content and could impact web compatibility! - are approved by an appropriate super-reviewer. They currently are:
@@ -14,6 +14,8 @@ After demonstrated competence not only at writing code for a component of Servo,
This verification will involve ensuring that a super-reviewer has ensured the proposed reviewer's reviews are consistent with the expectations of the project.
This verification will involve ensuring that a super-reviewer has ensured the proposed reviewer's reviews are consistent with the expectations of the project.
While review privileges are traditionally project-wide, it is also possible to have specific reviewer privileges for certain repositories. This is controlled using `extra_reviewers` in the Homu config, as opposed to the main reviewers list.
All those with access are expected to abide by and will be held to Mozilla's Commit Access Requirements:
All those with access are expected to abide by and will be held to Mozilla's Commit Access Requirements:
Core team
Servo is governed by a core team, which is ultimately responsible for all decision-making in the project. Specifically, the core team:
The core team currently consists of @larsbergstrom, @metajack, @jdm, and @pcwalton.
Reviewer privileges
After demonstrated competence not only at writing code for a component of Servo, but also at reviewing code within that component, we will consider granting review / merge privileges to new members. If you would like to consider having these permissions, please bring it up with @larsbergstrom and @metajack, and they will verify with an appropriate super-reviewer before granting review / merge privilege.
This verification will involve ensuring that a super-reviewer has ensured the proposed reviewer's reviews are consistent with the expectations of the project.
While review privileges are traditionally project-wide, it is also possible to have specific reviewer privileges for certain repositories. This is controlled using
extra_reviewersin the Homu config, as opposed to the main reviewers list.All those with access are expected to abide by and will be held to Mozilla's Commit Access Requirements: https://www.mozilla.org/en-US/about/governance/policies/commit/requirements/
Super-reviewers
While review privilege is global to Servo and all its associated projects, it is expected that significant changes in key areas - particularly that are exposed to web content and could impact web compatibility! - are approved by an appropriate super-reviewer. They currently are:
All reviewers
The list of all reviewers' GitHub names is available at: https://github.com/servo/saltfs/blob/master/homu/files/cfg.toml, which is the file that drives our installation of https://github.com/barosl/homu, our autolander and the only approved way to commit changes to the Servo repositories.