Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate the Linux functionality to use ARCs and make the Mac match. #7
+338
−47
Conversation
This comment has been minimized.
This comment has been minimized.
metajack
commented on 5ac0e3f
Jun 27, 2013
|
r+ |
|
This look good. I'm not sure why new_possibly_shared() is useful. Either you want a shared one, or you don't, but not being able to tell if you got a shared one or not seems less than ideal. |
metajack
added a commit
that referenced
this pull request
Jun 27, 2013
Update the Linux functionality to use ARCs and make the Mac match.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedJun 27, 2013
GLX contexts are not reference counted, so we must do the reference
counting ourselves, in Rust.
r? @metajack