This repository has been archived by the owner on Jun 8, 2020. It is now read-only.
Don't use FreeType on Windows MSVC #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors-servo r+ |
|
📌 Commit 472e190 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Aug 4, 2016
Don't use FreeType on Windows MSVC We don't want FreeType on Windows with MSVC, so don't try pulling it in. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/skia/104) <!-- Reviewable:end -->
|
@bors-servo clean retry |
bors-servo
pushed a commit
that referenced
this pull request
Aug 4, 2016
Don't use FreeType on Windows MSVC We don't want FreeType on Windows with MSVC, so don't try pulling it in. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/skia/104) <!-- Reviewable:end -->
|
I think this is failing. From: Hrm, trying to puzzle out what's going on here with all of the various jobs in-flight and strange reporting of "success" in the status boxes but failure to merge by homu. |
|
Aha, yes, it looks like the previous r+ also failed with this error: There's something wrong with the travis -> github status push update stuff? |
|
It looks like we are going to wait for servo/libexpat#18 to land before investigating this failure further. |
|
@bors-servo retry
|
|
@bors-servo r+ |
|
📌 Commit 48d989c has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Aug 5, 2016
Don't use FreeType on Windows MSVC We don't want FreeType on Windows with MSVC, so don't try pulling it in. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/skia/104) <!-- Reviewable:end -->
|
💥 Test timed out |
vvuk
force-pushed
the
msvcize
branch
2 times, most recently
from
85c06d0
to
f23dcb6
Compare
|
@bors-servo r+ |
|
📌 Commit ef67fd6 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Aug 6, 2016
Don't use FreeType on Windows MSVC We don't want FreeType on Windows with MSVC, so don't try pulling it in. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/skia/104) <!-- Reviewable:end -->
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want FreeType on Windows with MSVC, so don't try pulling it in.
This change is