This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDo not enable SSE3 globally #41
Merged
Conversation
Instead of enabling SSE3 instructions globally, only use it for files that specifically require those instructions. Skia will call that code based on a runtime check of processor features. Instead enable SSE2 globally except for opts_check_SSE2.cpp which requires extensions to be disabled to properly check processor features. Also fix a typo in the detection of i686, TARTET -> TARGET. Fixes #39.
|
I managed to fix this in parallel to #40, because I hadn't seen it. The two PRs are similar though this one is slightly more complete and will match the updated Skia more closely. |
This comment has been minimized.
This comment has been minimized.
metajack
commented on 4978fc7
Nov 18, 2014
|
r+ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mrobinson commentedNov 18, 2014
Instead of enabling SSE3 instructions globally, only use it for files
that specifically require those instructions. Skia will call that code
based on a runtime check of processor features. Instead enable SSE2
globally except for opts_check_SSE2.cpp which requires extensions to be
disabled to properly check processor features.
Also fix a typo in the detection of i686, TARTET -> TARGET.
Fixes #39.