This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upExclude a bunch of things from `cargo package`. #73
Conversation
Having servo fetch skia from crates.io would help with issues like #7687, as the compressed crate is 12 MB rather than 330 MB of git history. It’s still over the 10 MB limit of crates.io, though. This excludes some of the repository’s directory from the archive created by `cargo package` to bring it to 5 MB, while the "Verifying" phase (running `cargo build` from sources extracted again from the archive) still succeeds. Before we can publish skia we still need to publish all the recursive dependencies.
|
@bors-servo r+ Reviewed 1 of 1 files at r1. Comments from the review on Reviewable.io |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.
|
|
|
@bors-servo r+ |
|
|
bors-servo
pushed a commit
that referenced
this pull request
Sep 22, 2015
Exclude a bunch of things from `cargo package`. Having servo fetch skia from crates.io would help with issues like #7687, as the compressed crate is 12 MB rather than 330 MB of git history. It’s still over the 10 MB limit of crates.io, though. This excludes some of the repository’s directory from the archive created by `cargo package` to bring it to 5 MB, while the "Verifying" phase (running `cargo build` from sources extracted again from the archive) still succeeds. Before we can publish skia we still need to publish all the recursive dependencies. r? @mrobinson <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/skia/73) <!-- Reviewable:end -->
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SimonSapin commentedSep 22, 2015
Having servo fetch skia from crates.io would help with issues like #7687, as the compressed crate is 12 MB rather than 330 MB of git history. It’s still over the 10 MB limit of crates.io, though.
This excludes some of the repository’s directory from the archive created by
cargo packageto bring it to 5 MB, while the "Verifying" phase (runningcargo buildfrom sources extracted again from the archive)still succeeds.
Before we can publish skia we still need to publish all the recursive dependencies.
r? @mrobinson