Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSwitch to using std::sync instead of libsync #51
Merged
Conversation
libsync has been removed from rust, which means that for sync primitives, std::sync is required. This switches string-cache to using std::sync. Unfortunately, this means that string-cache now depends on both std and core.
kmcallister
added a commit
that referenced
this pull request
Dec 11, 2014
Switch to using std::sync instead of libsync
|
Thanks! I've opened #53 regarding that cleanup you mentioned. |
|
Thanks, I quickly ran through and changed the other imports for #54. Hopefully I didn't miss anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mystor commentedDec 7, 2014
libsync has been removed from rust, which means that for sync primitives, std::sync is required. This switches string-cache to using std::sync.
Unfortunately, this means that string-cache now depends on both std and core. A better patch which doesn't have this problem would probably be a good idea.