Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix OSMesa context creation error for GL 3.x versions #111
+5
−2
Conversation
src/platform/with_osmesa/mod.rs
Outdated
| @@ -38,7 +38,10 @@ impl OSMesaContext { | |||
| } | |||
|
|
|||
| let (major, minor) = match api_version { | |||
| GLVersion::Major(major) => (major, 1), // OpenGL 2.1, 3.1 | |||
| // OSMesa only suppots compatibility (non-Core) profiles in GL versions <= 3.0. | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
MortimerGoro commentedNov 1, 2017
•
edited
OSMesa context creation fails on Servo headless mode tests when using webgl 2.0 contexts.
This happens because OSMesa uses a OSMESA_COMPAT_PROFILE by default and it seems that it only supports compatibility profiles in GL versions <= 3.0 and core profiles for >= 3.1
With this PR:
A 3.0 compatibility profile is preferred for a major 3 context version (e.g. WebGL 2).
A 2.1 profile is created for a major 2 context version (e.g. WebGL 1).
In the future we could include a new setting to select Core/Compatibility profiles for all the backends.