Fix OSMesa context creation error for GL 3.x versions#111
Merged
jdm merged 1 commit intoservo:masterfrom Nov 1, 2017
Merged
Conversation
Eijebong
reviewed
Nov 1, 2017
src/platform/with_osmesa/mod.rs
Outdated
|
|
||
| let (major, minor) = match api_version { | ||
| GLVersion::Major(major) => (major, 1), // OpenGL 2.1, 3.1 | ||
| // OSMesa only suppots compatibility (non-Core) profiles in GL versions <= 3.0. |
MortimerGoro
force-pushed
the
osmesa_webgl2
branch
from
97fd428 to
6f236f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OSMesa context creation fails on Servo headless mode tests when using webgl 2.0 contexts.
This happens because OSMesa uses a OSMESA_COMPAT_PROFILE by default and it seems that it only supports compatibility profiles in GL versions <= 3.0 and core profiles for >= 3.1
With this PR:
A 3.0 compatibility profile is preferred for a major 3 context version (e.g. WebGL 2).
A 2.1 profile is created for a major 2 context version (e.g. WebGL 1).
In the future we could include a new setting to select Core/Compatibility profiles for all the backends.