Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uprust-geom API changes #13
Merged
Conversation
This was referenced Jun 12, 2015
|
There are a few more changes that need to be done in platform-specific code, by I'll take care of them :) I'll PR your PR and merge this when the changes land :P |
|
servo/rust-layers#178 and servo/euclid#81 have been merged |
I think I got all of them in my latest force push |
|
Yep, looks good :) |
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Jun 13, 2015
Shouldn't be merged until these have merged: servo/euclid#81 servo/surfman#13 servo/rust-layers#178 ~~I'll also need to update the Cargo lock files once they merge~~ <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6349) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Jun 13, 2015
Shouldn't be merged until these have merged: servo/euclid#81 servo/surfman#13 servo/rust-layers#178 ~~I'll also need to update the Cargo lock files once they merge~~ <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6349) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Jun 13, 2015
Shouldn't be merged until these have merged: servo/euclid#81 servo/surfman#13 servo/rust-layers#178 ~~I'll also need to update the Cargo lock files once they merge~~ <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6349) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Jun 13, 2015
Shouldn't be merged until these have merged: servo/euclid#81 servo/surfman#13 servo/rust-layers#178 ~~I'll also need to update the Cargo lock files once they merge~~ <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6349) <!-- Reviewable:end -->
jrmuizel
pushed a commit
to jrmuizel/gecko-cinnabar
that referenced
this pull request
Jun 12, 2017
…anges); r=pcwalton Shouldn't be merged until these have merged: servo/euclid#81 servo/surfman#13 servo/rust-layers#178 ~~I'll also need to update the Cargo lock files once they merge~~ Source-Repo: https://github.com/servo/servo Source-Revision: cfcd8589d06935f83b903f76477ea03e4d4652d0
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Sep 30, 2019
…anges); r=pcwalton Shouldn't be merged until these have merged: servo/euclid#81 servo/surfman#13 servo/rust-layers#178 ~~I'll also need to update the Cargo lock files once they merge~~ Source-Repo: https://github.com/servo/servo Source-Revision: cfcd8589d06935f83b903f76477ea03e4d4652d0 UltraBlame original commit: d70837d5150f00c1534f60d6ca265952259c90a3
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 1, 2019
…anges); r=pcwalton Shouldn't be merged until these have merged: servo/euclid#81 servo/surfman#13 servo/rust-layers#178 ~~I'll also need to update the Cargo lock files once they merge~~ Source-Repo: https://github.com/servo/servo Source-Revision: cfcd8589d06935f83b903f76477ea03e4d4652d0 UltraBlame original commit: d70837d5150f00c1534f60d6ca265952259c90a3
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
…anges); r=pcwalton Shouldn't be merged until these have merged: servo/euclid#81 servo/surfman#13 servo/rust-layers#178 ~~I'll also need to update the Cargo lock files once they merge~~ Source-Repo: https://github.com/servo/servo Source-Revision: cfcd8589d06935f83b903f76477ea03e4d4652d0 UltraBlame original commit: d70837d5150f00c1534f60d6ca265952259c90a3
asajeffrey
pushed a commit
to asajeffrey/surfman
that referenced
this pull request
Oct 18, 2019
Fix osmesa default build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
frewsxcv commentedJun 12, 2015
Shouldn't be merged until servo/euclid#81 has merged